Implement Android Executors for Storage #4830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended. |
Coverage Report 1Affected Products
Test Logs |
Unit Test Results 36 files ±0 36 suites ±0 6m 21s ⏱️ ±0s For more details on these failures, see this check. Results for commit 024171d. ± Comparison against base commit 4c833f6. ♻️ This comment has been updated with latest results. |
|
@rlazo - It seems like creating a |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
rlazo
reviewed
Mar 29, 2023
firebase-storage/src/main/java/com/google/firebase/storage/StorageRegistrar.java
Outdated
Show resolved
Hide resolved
firebase-storage/src/main/java/com/google/firebase/storage/FirebaseStorageComponent.java
Outdated
Show resolved
Hide resolved
I didn't see any changes to the tests , where did you made the change? |
I was referring to the change made here: https://github.com/firebase/firebase-android-sdk/pull/4830/files#diff-8a3cd8845e80a432177d61c12b761f03d6da86be0b22b62ee0de1d5341a8fbefR44 |
rlazo
approved these changes
Mar 29, 2023
|
If you sync past #4854 tests should start passing. Thanks! |
maneesht
force-pushed
the
mtewani/storage-android-executor
branch
from
948db98
to
7ed6c14
Compare
rlazo
reviewed
Apr 24, 2023
firebase-storage/src/test/java/com/google/firebase/storage/TestUtil.java
Outdated
Show resolved
Hide resolved
firebase-storage/src/testUtil/java/com/google/firebase/storage/TestUploadHelper.java
Outdated
Show resolved
Hide resolved
tonyjhuang
approved these changes
Apr 24, 2023
VinayGuthal
added a commit
that referenced
this pull request
Apr 26, 2023
This reverts commit 55e77f0.
VinayGuthal
added a commit
that referenced
this pull request
Apr 26, 2023
VinayGuthal
added a commit
that referenced
this pull request
Apr 26, 2023
This reverts commit 55e77f0.
VinayGuthal
added a commit
that referenced
this pull request
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go/firebase-android-executors