Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Refactor PublishingPlugin" #4937

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Revert "Refactor PublishingPlugin" #4937

merged 1 commit into from
Apr 26, 2023

Conversation

VinayGuthal
Copy link
Contributor

Reverts #4923

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023 •
edited

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@rlazo rlazo merged commit 90a9367 into master Apr 26, 2023
13 of 14 checks passed
@rlazo rlazo deleted the revert-4923-daymon-migrate-publishingplugin branch April 26, 2023 19:32
VinayGuthal added a commit that referenced this pull request Apr 26, 2023
@VinayGuthal
Revert "Revert "Refactor PublishingPlugin (#4923)" (#4937)"
18fd1e7 
This reverts commit 90a9367.
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (55e77f0) and merge commit (49b6604).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/APekAeaoft.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.19% (55e77f0) to 50.23% (49b6604) by +0.04%.

    FilenameBase (55e77f0)Merge (49b6604)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-firestore

    Overall coverage changed from 44.24% (55e77f0) to 44.24% (49b6604) by -0.00%.

    FilenameBase (55e77f0)Merge (49b6604)Diff
    PatchMutation.java100.00%98.39%-1.61%

  • firebase-storage

    Overall coverage changed from 85.77% (55e77f0) to 86.11% (49b6604) by +0.34%.

    FilenameBase (55e77f0)Merge (49b6604)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    UploadTask.java81.85%83.17%+1.32%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/f2qtIWnTyy.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (117,057 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Pe3Zp2RvYg/index.html

VinayGuthal added a commit that referenced this pull request Apr 26, 2023
@VinayGuthal @maneesht
Revert 4923 daymon migrate publishingplugin (#4945)
6d45825 
* Implement Android Executors for Storage (#4830)

* Revert "Refactor PublishingPlugin (#4923)" (#4937)

This reverts commit 0efc6c7.

* Revert "Refactor PublishingPlugin (#4923)"

This reverts commit 0efc6c7.

---------

Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com>
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VinayGuthal @google-oss-bot @rlazo