Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages printed in Logcat #518

Closed
senthilzc opened this issue Jun 10, 2019 · 7 comments

Comments

@senthilzc
Copy link

commented Jun 10, 2019

Step 1: Describe your environment

  • Android device: Samsung S9 Plus
  • Android OS version: Android 9.0 Pie
  • Google Play Services version: 15.1.28-all
  • Firebase/Play Services SDK version: 18.0.0/15.0.1

Step 2: Describe the problem:

Steps to reproduce:

  1. Run the sample project
  2. Click Open Button from the list

Observed Results:

  • In the logcat, the message sent is being printed

Expected Results:

  • Message sent should not be logged.

Relevant Code:

ArrayList<Message> messageList = new ArrayList<>();
messageList.add(new Message("Hello. How are you?", false, System.currentTimeMillis()));

Screenshot from 2019-06-10 11-45-25

  List<FirebaseTextMessage> chatHistory = new ArrayList<>();
        for (Message message : messageList) {
            if (message.isLocalUser && !isEmulatingRemoteUser || !message.isLocalUser && isEmulatingRemoteUser) {
                chatHistory.add(FirebaseTextMessage.createForLocalUser(message.text,
                        message.timestamp));
            } else {
                chatHistory.add(FirebaseTextMessage.createForRemoteUser(message.text,
                        message.timestamp, REMOTE_USER_ID));
            }
        }
       FirebaseNaturalLanguage.getInstance().getSmartReply().suggestReplies(chatHistory)
                .continueWith(new Continuation<SmartReplySuggestionResult, List<SmartReplySuggestion>>() {
                    @Override
                    public List<SmartReplySuggestion> then(@NonNull Task<SmartReplySuggestionResult> task) {
                        return task.getResult().getSuggestions();
                    }
                });

@senthilzc senthilzc changed the title Smart Reply printing Message Log Messages printed in Logcat Jun 10, 2019

@senthilzc

This comment has been minimized.

Copy link
Author

commented Jun 10, 2019

Screenshot from 2019-06-10 11-45-25

@samtstern

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

@senthilzc thanks for reporting this! Looks like those logs come from within the MLKit SDK not the quickstart so I am going to transfer this issue.

@samtstern samtstern transferred this issue from firebase/quickstart-android Jun 13, 2019

@google-oss-bot

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@samtstern

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Tracking internally as http://b/135199350

@senthilzc

This comment has been minimized.

Copy link
Author

commented Jul 16, 2019

@samtstern is the issue fixed internally?

@samtstern

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

@senthilzc no there is no update yet, I will close this when there is.

@samtstern

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

We have just merged a fix for this internally and it will be be fixed in the next public release. Thanks for reporting!

@samtstern samtstern closed this Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.