Remove application-id from macrobenchmark config file. #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update version for some dependencies - shorten the name of benchmark test class
Binary Size ReportAffected SDKsNo changes between base commit (b5d06cd) and head commit (0595e450). Test Logs
NotesHead commit (0595e450) is created by Prow via merging commits: b5d06cd 7a39540. |
Macrobenchmark ReportAffected SDKsMeasurements are for head commit (7a39540). Diffing against base commit (ff8f905) is working in progress.
|
|
/retest |
rlazo
approved these changes
May 25, 2021
|
/retest |
1 similar comment
|
/retest |
vkryachko
approved these changes
May 25, 2021
| dependencies: | ||
| - com.google.firebase:firebase-crashlytics-ktx | ||
| plugins: | ||
| - com.google.firebase.crashlytics | ||
|
|
||
| firebase-database: | ||
| name: database | ||
| application-id: com.google.firebase.benchmark.database | ||
| dependencies: | ||
| - com.google.firebase:firebase-database-ktx | ||
|
|
||
| firebase-dynamic-links: | ||
| name: dynamiclinks |
There was a problem hiding this comment.
No immediate action required, but what is the purpose of the name given that we already have the section already named(i.e. firebase-dynamic-links)?
There was a problem hiding this comment.
In the beginning, I thought there can be multiple apps built for one SDK, and this name can be used to distinguish those apps, but I suppose that is no longer the case. Right now it's used as part of the dir path for the generated test apps, but it is not necessary to have it in the path. Removing it requires some change, which I'll defer to a followup PR.
Regarding to application id, now that we only need one application id, I'm planning to add it to fireescape-integ-tests so that I can just use preset-google-services in prow jobs. What do you think?
|
/retest |
|
/test check-changed |
1 similar comment
|
/test check-changed |
|
/retest |
|
/test check-changed |
5 similar comments
|
/test check-changed |
|
/test check-changed |
|
/test check-changed |
|
/test check-changed |
|
/test check-changed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update version for some dependencies.