Fix logs, breadcrumbs and custom keys for ANRs #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and SessionReportingCoordinator
…s and Exception nullable
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (2e98b5c5) is created by Prow via merging commits: ac38b9a 2c8ee59. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (2e98b5c5) is created by Prow via merging commits: ac38b9a 2c8ee59. |
tejasd
changed the title
Macrobenchmark ReportAffected SDKsMeasurements are for head commit (339e3be). Diffing against base commit (ca67b3f) is working in progress.
|
pydichandra
approved these changes
Jun 22, 2021
| relevantUserMetadata.setCustomKeys(new MetaDataStore(getFilesDir()).readKeyData(sessionId)); | ||
| reportingCoordinator.persistAppExitInfoEvent( | ||
| sessionId, | ||
| applicationExitInfoList.get(0), |
There was a problem hiding this comment.
I am assuming single app_exit_info entry gets created for app exit (and not multiple app_exit_info entries eg., ANR and OOM after an app exit). Is this assumption correct?
There was a problem hiding this comment.
That assumption is most likely correct., but the documentation doesn't explicitly mention it, and I haven't looked at the implementation yet - but it does imply (https://developer.android.com/reference/kotlin/android/app/ApplicationExitInfo#gettraceinputstream)
However, we're currently only collecting ANRs, and so it's ok to only collect the last app_exit_info.
|
@tejasd: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.