Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin these for M129 #4807

Merged
merged 3 commits into from Mar 21, 2023
Merged

pin these for M129 #4807

merged 3 commits into from Mar 21, 2023

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@VinayGuthal
Copy link
Contributor

Update app-distribtuion to depend on installations@17.1.3 instead of 17.1.2

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 21, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

Unit Test Results

  40 files   -    118    40 suites   - 118   1m 38s ⏱️ -38s
203 tests  -    914  203 ✔️  -    898  0 💤  - 16  0 ±0 
406 runs   - 1 828  406 ✔️  - 1 796  0 💤  - 32  0 ±0 

Results for commit 4dbb4fb. ± Comparison against base commit 47e7a88.

♻️ This comment has been updated with latest results.

@VinayGuthal VinayGuthal self-requested a review March 21, 2023 18:42
@google-oss-bot
Copy link
Contributor

@davidmotson davidmotson merged commit 71772b3 into master Mar 21, 2023
20 of 21 checks passed
@davidmotson davidmotson deleted the davidmotson.pin_more_version branch March 21, 2023 19:14
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-appdistribution

    DeviceStatisticsDistributions
    oriole-32
    Percentile47e7a88bae8bedDiffSignificant (?)
    p101.11 ±0.9 ms1.35 ±0.8 ms+237 μs (+21.3%)NO
    p251.16 ±0.9 ms1.40 ±0.8 ms+245 μs (+21.2%)NO
    p501.22 ±0.9 ms1.48 ±0.9 ms+254 μs (+20.7%)NO
    p751.39 ±1 ms1.64 ±0.9 ms+251 μs (+18.1%)NO
    p901.62 ±1 ms1.97 ±1 ms+343 μs (+21.1%)NO

    20 test runs in comparison
    CommitTest Runs
    47e7a88
    • 2023-03-20_22:59:07.222837_LfDg
    • 2023-03-20_22:59:07.227049_jqpt
    • 2023-03-20_22:59:07.227079_kdqG
    • 2023-03-20_22:59:07.227095_GhhT
    • 2023-03-20_22:59:07.227103_qaZw
    • 2023-03-20_22:59:07.227116_EfAu
    • 2023-03-20_22:59:07.227302_zHFV
    • 2023-03-20_22:59:07.227312_ZrVG
    • 2023-03-20_22:59:07.227319_vAot
    • 2023-03-20_22:59:07.227327_CIfG
    bae8bed
    • 2023-03-21_19:01:24.072854_OFgg
    • 2023-03-21_19:01:24.075607_QuEh
    • 2023-03-21_19:01:24.075618_QvOn
    • 2023-03-21_19:01:24.075624_GaOh
    • 2023-03-21_19:01:24.075630_DUIl
    • 2023-03-21_19:01:24.075636_qvgb
    • 2023-03-21_19:01:24.075642_xyPg
    • 2023-03-21_19:01:24.075647_nPaT
    • 2023-03-21_19:01:24.075652_pYoY
    • 2023-03-21_19:01:24.075658_csZF
    redfin-30
    Percentile47e7a88bae8bedDiffSignificant (?)
    p101.72 ±2 ms1.70 ±2 ms-13.0 μs (-0.8%)NO
    p251.79 ±2 ms1.77 ±2 ms-23.3 μs (-1.3%)NO
    p501.91 ±2 ms1.87 ±2 ms-42.5 μs (-2.2%)NO
    p752.06 ±2 ms2.02 ±2 ms-41.3 μs (-2.0%)NO
    p902.31 ±2 ms2.29 ±2 ms-25.0 μs (-1.1%)NO

    20 test runs in comparison
    CommitTest Runs
    47e7a88
    • 2023-03-20_22:59:07.222837_LfDg
    • 2023-03-20_22:59:07.227049_jqpt
    • 2023-03-20_22:59:07.227079_kdqG
    • 2023-03-20_22:59:07.227095_GhhT
    • 2023-03-20_22:59:07.227103_qaZw
    • 2023-03-20_22:59:07.227116_EfAu
    • 2023-03-20_22:59:07.227302_zHFV
    • 2023-03-20_22:59:07.227312_ZrVG
    • 2023-03-20_22:59:07.227319_vAot
    • 2023-03-20_22:59:07.227327_CIfG
    bae8bed
    • 2023-03-21_19:01:24.072854_OFgg
    • 2023-03-21_19:01:24.075607_QuEh
    • 2023-03-21_19:01:24.075618_QvOn
    • 2023-03-21_19:01:24.075624_GaOh
    • 2023-03-21_19:01:24.075630_DUIl
    • 2023-03-21_19:01:24.075636_qvgb
    • 2023-03-21_19:01:24.075642_xyPg
    • 2023-03-21_19:01:24.075647_nPaT
    • 2023-03-21_19:01:24.075652_pYoY
    • 2023-03-21_19:01:24.075658_csZF
  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentile47e7a88bae8bedDiffSignificant (?)
    p109.75 ±2 ms9.96 ±3 ms+219 μs (+2.2%)NO
    p2510.5 ±2 ms10.8 ±3 ms+266 μs (+2.5%)NO
    p5011.4 ±2 ms11.9 ±3 ms+447 μs (+3.9%)NO
    p7512.7 ±2 ms13.2 ±3 ms+547 μs (+4.3%)NO
    p9014.2 ±2 ms14.8 ±3 ms+584 μs (+4.1%)NO

    20 test runs in comparison
    CommitTest Runs
    47e7a88
    • 2023-03-20_22:59:07.222837_LfDg
    • 2023-03-20_22:59:07.227049_jqpt
    • 2023-03-20_22:59:07.227079_kdqG
    • 2023-03-20_22:59:07.227095_GhhT
    • 2023-03-20_22:59:07.227103_qaZw
    • 2023-03-20_22:59:07.227116_EfAu
    • 2023-03-20_22:59:07.227302_zHFV
    • 2023-03-20_22:59:07.227312_ZrVG
    • 2023-03-20_22:59:07.227319_vAot
    • 2023-03-20_22:59:07.227327_CIfG
    bae8bed
    • 2023-03-21_19:01:24.072854_OFgg
    • 2023-03-21_19:01:24.075607_QuEh
    • 2023-03-21_19:01:24.075618_QvOn
    • 2023-03-21_19:01:24.075624_GaOh
    • 2023-03-21_19:01:24.075630_DUIl
    • 2023-03-21_19:01:24.075636_qvgb
    • 2023-03-21_19:01:24.075642_xyPg
    • 2023-03-21_19:01:24.075647_nPaT
    • 2023-03-21_19:01:24.075652_pYoY
    • 2023-03-21_19:01:24.075658_csZF
    redfin-30
    Percentile47e7a88bae8bedDiffSignificant (?)
    p1016.0 ±7 ms15.8 ±7 ms-182 μs (-1.1%)NO
    p2517.1 ±8 ms17.0 ±7 ms-97.9 μs (-0.6%)NO
    p5018.7 ±9 ms18.5 ±8 ms-245 μs (-1.3%)NO
    p7520.5 ±9 ms20.8 ±9.7 ms+255 μs (+1.2%)NO
    p9023.4 ±10 ms24.1 ±11 ms+707 μs (+3.0%)NO

    20 test runs in comparison
    CommitTest Runs
    47e7a88
    • 2023-03-20_22:59:07.222837_LfDg
    • 2023-03-20_22:59:07.227049_jqpt
    • 2023-03-20_22:59:07.227079_kdqG
    • 2023-03-20_22:59:07.227095_GhhT
    • 2023-03-20_22:59:07.227103_qaZw
    • 2023-03-20_22:59:07.227116_EfAu
    • 2023-03-20_22:59:07.227302_zHFV
    • 2023-03-20_22:59:07.227312_ZrVG
    • 2023-03-20_22:59:07.227319_vAot
    • 2023-03-20_22:59:07.227327_CIfG
    bae8bed
    • 2023-03-21_19:01:24.072854_OFgg
    • 2023-03-21_19:01:24.075607_QuEh
    • 2023-03-21_19:01:24.075618_QvOn
    • 2023-03-21_19:01:24.075624_GaOh
    • 2023-03-21_19:01:24.075630_DUIl
    • 2023-03-21_19:01:24.075636_qvgb
    • 2023-03-21_19:01:24.075642_xyPg
    • 2023-03-21_19:01:24.075647_nPaT
    • 2023-03-21_19:01:24.075652_pYoY
    • 2023-03-21_19:01:24.075658_csZF
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile47e7a88bae8bedDiffSignificant (?)
    p10189 ±2 ms204 ±15 ms+14.9 ms (+7.9%)NO
    p25195 ±3 ms211 ±16 ms+16.3 ms (+8.3%)NO
    p50202 ±3 ms222 ±21 ms+19.8 ms (+9.8%)NO
    p75209 ±3 ms233 ±24 ms+23.5 ms (+11.2%)NO
    p90217 ±4 ms243 ±24 ms+26.2 ms (+12.1%)NO

    20 test runs in comparison
    CommitTest Runs
    47e7a88
    • 2023-03-20_22:59:07.222837_LfDg
    • 2023-03-20_22:59:07.227049_jqpt
    • 2023-03-20_22:59:07.227079_kdqG
    • 2023-03-20_22:59:07.227095_GhhT
    • 2023-03-20_22:59:07.227103_qaZw
    • 2023-03-20_22:59:07.227116_EfAu
    • 2023-03-20_22:59:07.227302_zHFV
    • 2023-03-20_22:59:07.227312_ZrVG
    • 2023-03-20_22:59:07.227319_vAot
    • 2023-03-20_22:59:07.227327_CIfG
    bae8bed
    • 2023-03-21_19:01:24.072854_OFgg
    • 2023-03-21_19:01:24.075607_QuEh
    • 2023-03-21_19:01:24.075618_QvOn
    • 2023-03-21_19:01:24.075624_GaOh
    • 2023-03-21_19:01:24.075630_DUIl
    • 2023-03-21_19:01:24.075636_qvgb
    • 2023-03-21_19:01:24.075642_xyPg
    • 2023-03-21_19:01:24.075647_nPaT
    • 2023-03-21_19:01:24.075652_pYoY
    • 2023-03-21_19:01:24.075658_csZF
    redfin-30
    Percentile47e7a88bae8bedDiffSignificant (?)
    p10233 ±13 ms255 ±4 ms+22.3 ms (+9.6%)NO
    p25240 ±14 ms262 ±4 ms+21.7 ms (+9.1%)NO
    p50247 ±16 ms269 ±3 ms+22.7 ms (+9.2%)NO
    p75259 ±28 ms279 ±4 ms+20.4 ms (+7.9%)NO
    p90270 ±31 ms293 ±8 ms+23.2 ms (+8.6%)NO

    20 test runs in comparison
    CommitTest Runs
    47e7a88
    • 2023-03-20_22:59:07.222837_LfDg
    • 2023-03-20_22:59:07.227049_jqpt
    • 2023-03-20_22:59:07.227079_kdqG
    • 2023-03-20_22:59:07.227095_GhhT
    • 2023-03-20_22:59:07.227103_qaZw
    • 2023-03-20_22:59:07.227116_EfAu
    • 2023-03-20_22:59:07.227302_zHFV
    • 2023-03-20_22:59:07.227312_ZrVG
    • 2023-03-20_22:59:07.227319_vAot
    • 2023-03-20_22:59:07.227327_CIfG
    bae8bed
    • 2023-03-21_19:01:24.072854_OFgg
    • 2023-03-21_19:01:24.075607_QuEh
    • 2023-03-21_19:01:24.075618_QvOn
    • 2023-03-21_19:01:24.075624_GaOh
    • 2023-03-21_19:01:24.075630_DUIl
    • 2023-03-21_19:01:24.075636_qvgb
    • 2023-03-21_19:01:24.075642_xyPg
    • 2023-03-21_19:01:24.075647_nPaT
    • 2023-03-21_19:01:24.075652_pYoY
    • 2023-03-21_19:01:24.075658_csZF

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UwwfNnPWJN/index.html

emilypgoogle pushed a commit that referenced this pull request Mar 21, 2023
* pin these for M129

* bump slightly

* re-pin well known types

---------

Co-authored-by: David Motsonashvili <davidmotson@google.com>
@firebase firebase locked and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants