Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for URLConnection.getInputStream() Crashing #5615

Closed
wants to merge 5 commits into from
Closed

Fix for URLConnection.getInputStream() Crashing #5615

wants to merge 5 commits into from

Conversation

argzdev
Copy link
Contributor

@argzdev argzdev commented Dec 27, 2023

Proposed fix for #5584:

Issue

Crash happens if a URL connection is opened e.g. url.openStream() when FirebasePerformance has not been initialized.

Investigation

  1. openStream in FirebasePerfUrlConnection intercepts all urls that opens connections.
  2. openStream requires TransportManager to be initialized
  3. TransportManager is only initialized after FirebasePerformance has been initialized

Solution

If TransportManager is not initialized, we should simply return the URL openStream and not intercept the connection.

@argzdev argzdev closed this Dec 27, 2023
@firebase firebase locked and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants