Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more tests #6072

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Fix more tests #6072

merged 3 commits into from
Jul 3, 2024

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Jul 3, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@mrober mrober enabled auto-merge (squash) July 3, 2024 17:46
@google-oss-bot
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Unit Test Results

  6 files   -      942    6 suites   - 942   21s ⏱️ - 35m 39s
19 tests  -   5 191  19 ✔️  -   5 170  0 💤  - 21  0 ±0 
38 runs   - 10 467  38 ✔️  - 10 425  0 💤  - 42  0 ±0 

Results for commit 132e25d. ± Comparison against base commit 93445d6.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentile93445d6819fbe9DiffSignificant (?)
    p1010.5 ±3 ms9.40 ±1 ms-1.07 ms (-10.2%)NO
    p2511.1 ±3 ms9.99 ±1 ms-1.08 ms (-9.7%)NO
    p5012.1 ±3 ms10.9 ±1 ms-1.17 ms (-9.7%)NO
    p7513.4 ±3 ms12.1 ±1 ms-1.32 ms (-9.8%)NO
    p9015.1 ±3 ms13.6 ±1 ms-1.43 ms (-9.5%)NO

    20 test runs in comparison
    CommitTest Runs
    93445d6
    • 2024-07-03_16:24:31.472149_vKnf
    • 2024-07-03_16:24:31.472193_vnVb
    • 2024-07-03_16:24:31.472203_Ypfc
    • 2024-07-03_16:24:31.472210_HfYt
    • 2024-07-03_16:24:31.472218_VXcm
    • 2024-07-03_16:24:31.472225_JqQB
    • 2024-07-03_16:24:31.472233_PZBc
    • 2024-07-03_16:24:31.472240_BbOt
    • 2024-07-03_16:24:31.472248_DcLg
    • 2024-07-03_16:24:31.472256_gzDW
    819fbe9
    • 2024-07-03_17:57:54.023579_Bydn
    • 2024-07-03_17:57:54.023623_DaYN
    • 2024-07-03_17:57:54.023633_vNNS
    • 2024-07-03_17:57:54.023641_bbad
    • 2024-07-03_17:57:54.023648_WlRd
    • 2024-07-03_17:57:54.023655_zIgr
    • 2024-07-03_17:57:54.023662_CYJb
    • 2024-07-03_17:57:54.023669_BLQQ
    • 2024-07-03_17:57:54.023676_lUzf
    • 2024-07-03_17:57:54.023683_iTBE
    redfin-30
    Percentile93445d6819fbe9DiffSignificant (?)
    p1013.3 ±3 ms13.2 ±3 ms-94.8 μs (-0.7%)NO
    p2514.0 ±4 ms14.0 ±4 ms+19.2 μs (+0.1%)NO
    p5015.0 ±4 ms15.0 ±4 ms-76.8 μs (-0.5%)NO
    p7516.4 ±5 ms16.6 ±4 ms+211 μs (+1.3%)NO
    p9018.6 ±6 ms19.2 ±5 ms+616 μs (+3.3%)NO

    20 test runs in comparison
    CommitTest Runs
    93445d6
    • 2024-07-03_16:24:31.472149_vKnf
    • 2024-07-03_16:24:31.472193_vnVb
    • 2024-07-03_16:24:31.472203_Ypfc
    • 2024-07-03_16:24:31.472210_HfYt
    • 2024-07-03_16:24:31.472218_VXcm
    • 2024-07-03_16:24:31.472225_JqQB
    • 2024-07-03_16:24:31.472233_PZBc
    • 2024-07-03_16:24:31.472240_BbOt
    • 2024-07-03_16:24:31.472248_DcLg
    • 2024-07-03_16:24:31.472256_gzDW
    819fbe9
    • 2024-07-03_17:57:54.023579_Bydn
    • 2024-07-03_17:57:54.023623_DaYN
    • 2024-07-03_17:57:54.023633_vNNS
    • 2024-07-03_17:57:54.023641_bbad
    • 2024-07-03_17:57:54.023648_WlRd
    • 2024-07-03_17:57:54.023655_zIgr
    • 2024-07-03_17:57:54.023662_CYJb
    • 2024-07-03_17:57:54.023669_BLQQ
    • 2024-07-03_17:57:54.023676_lUzf
    • 2024-07-03_17:57:54.023683_iTBE
  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentile93445d6819fbe9DiffSignificant (?)
    p10261 ±388 μs240 ±399 μs-21.4 μs (-8.2%)NO
    p25272 ±401 μs255 ±418 μs-17.2 μs (-6.3%)NO
    p50288 ±414 μs272 ±437 μs-16.1 μs (-5.6%)NO
    p75331 ±455 μs307 ±472 μs-24.4 μs (-7.4%)NO
    p90429 ±531 μs367 ±513 μs-61.8 μs (-14.4%)NO

    20 test runs in comparison
    CommitTest Runs
    93445d6
    • 2024-07-03_16:24:31.472149_vKnf
    • 2024-07-03_16:24:31.472193_vnVb
    • 2024-07-03_16:24:31.472203_Ypfc
    • 2024-07-03_16:24:31.472210_HfYt
    • 2024-07-03_16:24:31.472218_VXcm
    • 2024-07-03_16:24:31.472225_JqQB
    • 2024-07-03_16:24:31.472233_PZBc
    • 2024-07-03_16:24:31.472240_BbOt
    • 2024-07-03_16:24:31.472248_DcLg
    • 2024-07-03_16:24:31.472256_gzDW
    819fbe9
    • 2024-07-03_17:57:54.023579_Bydn
    • 2024-07-03_17:57:54.023623_DaYN
    • 2024-07-03_17:57:54.023633_vNNS
    • 2024-07-03_17:57:54.023641_bbad
    • 2024-07-03_17:57:54.023648_WlRd
    • 2024-07-03_17:57:54.023655_zIgr
    • 2024-07-03_17:57:54.023662_CYJb
    • 2024-07-03_17:57:54.023669_BLQQ
    • 2024-07-03_17:57:54.023676_lUzf
    • 2024-07-03_17:57:54.023683_iTBE
    redfin-30
    Percentile93445d6819fbe9DiffSignificant (?)
    p10213 ±126 μs240 ±219 μs+26.5 μs (+12.4%)NO
    p25242 ±174 μs266 ±268 μs+24.1 μs (+10.0%)NO
    p50316 ±311 μs340 ±410 μs+23.9 μs (+7.6%)NO
    p75411 ±462 μs448 ±588 μs+37.1 μs (+9.0%)NO
    p90561 ±699 μs596 ±779 μs+34.7 μs (+6.2%)NO

    20 test runs in comparison
    CommitTest Runs
    93445d6
    • 2024-07-03_16:24:31.472149_vKnf
    • 2024-07-03_16:24:31.472193_vnVb
    • 2024-07-03_16:24:31.472203_Ypfc
    • 2024-07-03_16:24:31.472210_HfYt
    • 2024-07-03_16:24:31.472218_VXcm
    • 2024-07-03_16:24:31.472225_JqQB
    • 2024-07-03_16:24:31.472233_PZBc
    • 2024-07-03_16:24:31.472240_BbOt
    • 2024-07-03_16:24:31.472248_DcLg
    • 2024-07-03_16:24:31.472256_gzDW
    819fbe9
    • 2024-07-03_17:57:54.023579_Bydn
    • 2024-07-03_17:57:54.023623_DaYN
    • 2024-07-03_17:57:54.023633_vNNS
    • 2024-07-03_17:57:54.023641_bbad
    • 2024-07-03_17:57:54.023648_WlRd
    • 2024-07-03_17:57:54.023655_zIgr
    • 2024-07-03_17:57:54.023662_CYJb
    • 2024-07-03_17:57:54.023669_BLQQ
    • 2024-07-03_17:57:54.023676_lUzf
    • 2024-07-03_17:57:54.023683_iTBE
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentile93445d6819fbe9DiffSignificant (?)
    p102.72 ±0.3 ms2.61 ±0.2 ms-109 μs (-4.0%)NO
    p252.91 ±0.4 ms2.81 ±0.3 ms-99.1 μs (-3.4%)NO
    p503.25 ±0.4 ms3.17 ±0.4 ms-80.8 μs (-2.5%)NO
    p753.79 ±0.6 ms3.70 ±0.5 ms-99.2 μs (-2.6%)NO
    p904.58 ±0.7 ms4.51 ±0.7 ms-74.3 μs (-1.6%)NO

    20 test runs in comparison
    CommitTest Runs
    93445d6
    • 2024-07-03_16:24:31.472149_vKnf
    • 2024-07-03_16:24:31.472193_vnVb
    • 2024-07-03_16:24:31.472203_Ypfc
    • 2024-07-03_16:24:31.472210_HfYt
    • 2024-07-03_16:24:31.472218_VXcm
    • 2024-07-03_16:24:31.472225_JqQB
    • 2024-07-03_16:24:31.472233_PZBc
    • 2024-07-03_16:24:31.472240_BbOt
    • 2024-07-03_16:24:31.472248_DcLg
    • 2024-07-03_16:24:31.472256_gzDW
    819fbe9
    • 2024-07-03_17:57:54.023579_Bydn
    • 2024-07-03_17:57:54.023623_DaYN
    • 2024-07-03_17:57:54.023633_vNNS
    • 2024-07-03_17:57:54.023641_bbad
    • 2024-07-03_17:57:54.023648_WlRd
    • 2024-07-03_17:57:54.023655_zIgr
    • 2024-07-03_17:57:54.023662_CYJb
    • 2024-07-03_17:57:54.023669_BLQQ
    • 2024-07-03_17:57:54.023676_lUzf
    • 2024-07-03_17:57:54.023683_iTBE
    redfin-30
    Percentile93445d6819fbe9DiffSignificant (?)
    p106.24 ±1 ms6.31 ±1 ms+71.5 μs (+1.1%)NO
    p256.71 ±2 ms6.84 ±2 ms+132 μs (+2.0%)NO
    p507.31 ±2 ms7.51 ±2 ms+198 μs (+2.7%)NO
    p758.36 ±3 ms8.43 ±3 ms+66.6 μs (+0.8%)NO
    p909.74 ±4 ms9.77 ±5 ms+33.1 μs (+0.3%)NO

    20 test runs in comparison
    CommitTest Runs
    93445d6
    • 2024-07-03_16:24:31.472149_vKnf
    • 2024-07-03_16:24:31.472193_vnVb
    • 2024-07-03_16:24:31.472203_Ypfc
    • 2024-07-03_16:24:31.472210_HfYt
    • 2024-07-03_16:24:31.472218_VXcm
    • 2024-07-03_16:24:31.472225_JqQB
    • 2024-07-03_16:24:31.472233_PZBc
    • 2024-07-03_16:24:31.472240_BbOt
    • 2024-07-03_16:24:31.472248_DcLg
    • 2024-07-03_16:24:31.472256_gzDW
    819fbe9
    • 2024-07-03_17:57:54.023579_Bydn
    • 2024-07-03_17:57:54.023623_DaYN
    • 2024-07-03_17:57:54.023633_vNNS
    • 2024-07-03_17:57:54.023641_bbad
    • 2024-07-03_17:57:54.023648_WlRd
    • 2024-07-03_17:57:54.023655_zIgr
    • 2024-07-03_17:57:54.023662_CYJb
    • 2024-07-03_17:57:54.023669_BLQQ
    • 2024-07-03_17:57:54.023676_lUzf
    • 2024-07-03_17:57:54.023683_iTBE
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile93445d6819fbe9DiffSignificant (?)
    p10200 ±5 ms203 ±3 ms+3.18 ms (+1.6%)NO
    p25206 ±5 ms209 ±3 ms+3.68 ms (+1.8%)NO
    p50213 ±5 ms216 ±3 ms+3.54 ms (+1.7%)NO
    p75221 ±5 ms225 ±5 ms+4.22 ms (+1.9%)NO
    p90229 ±5 ms234 ±7 ms+4.78 ms (+2.1%)NO

    20 test runs in comparison
    CommitTest Runs
    93445d6
    • 2024-07-03_16:24:31.472149_vKnf
    • 2024-07-03_16:24:31.472193_vnVb
    • 2024-07-03_16:24:31.472203_Ypfc
    • 2024-07-03_16:24:31.472210_HfYt
    • 2024-07-03_16:24:31.472218_VXcm
    • 2024-07-03_16:24:31.472225_JqQB
    • 2024-07-03_16:24:31.472233_PZBc
    • 2024-07-03_16:24:31.472240_BbOt
    • 2024-07-03_16:24:31.472248_DcLg
    • 2024-07-03_16:24:31.472256_gzDW
    819fbe9
    • 2024-07-03_17:57:54.023579_Bydn
    • 2024-07-03_17:57:54.023623_DaYN
    • 2024-07-03_17:57:54.023633_vNNS
    • 2024-07-03_17:57:54.023641_bbad
    • 2024-07-03_17:57:54.023648_WlRd
    • 2024-07-03_17:57:54.023655_zIgr
    • 2024-07-03_17:57:54.023662_CYJb
    • 2024-07-03_17:57:54.023669_BLQQ
    • 2024-07-03_17:57:54.023676_lUzf
    • 2024-07-03_17:57:54.023683_iTBE
    redfin-30
    Percentile93445d6819fbe9DiffSignificant (?)
    p10241 ±4 ms265 ±7 ms+24.2 ms (+10.0%)MAYBE
    p25246 ±4 ms271 ±6 ms+24.6 ms (+10.0%)MAYBE
    p50252 ±5 ms277 ±7 ms+25.5 ms (+10.1%)MAYBE
    p75259 ±6 ms286 ±8 ms+27.5 ms (+10.6%)MAYBE
    p90268 ±7 ms297 ±10 ms+28.8 ms (+10.7%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    93445d6
    • 2024-07-03_16:24:31.472149_vKnf
    • 2024-07-03_16:24:31.472193_vnVb
    • 2024-07-03_16:24:31.472203_Ypfc
    • 2024-07-03_16:24:31.472210_HfYt
    • 2024-07-03_16:24:31.472218_VXcm
    • 2024-07-03_16:24:31.472225_JqQB
    • 2024-07-03_16:24:31.472233_PZBc
    • 2024-07-03_16:24:31.472240_BbOt
    • 2024-07-03_16:24:31.472248_DcLg
    • 2024-07-03_16:24:31.472256_gzDW
    819fbe9
    • 2024-07-03_17:57:54.023579_Bydn
    • 2024-07-03_17:57:54.023623_DaYN
    • 2024-07-03_17:57:54.023633_vNNS
    • 2024-07-03_17:57:54.023641_bbad
    • 2024-07-03_17:57:54.023648_WlRd
    • 2024-07-03_17:57:54.023655_zIgr
    • 2024-07-03_17:57:54.023662_CYJb
    • 2024-07-03_17:57:54.023669_BLQQ
    • 2024-07-03_17:57:54.023676_lUzf
    • 2024-07-03_17:57:54.023683_iTBE

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/q3hbwBAMMF/index.html

@mrober mrober merged commit d11959b into main Jul 3, 2024
35 checks passed
@mrober mrober deleted the crashlytics-anr-tests branch July 3, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants