Decouple user metadata from Crashlytics backend worker #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
mrober
approved these changes
Jul 3, 2024
themiswang
merged commit c1265fc
into
crashlytics-exception-handler
24 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
CrashlyticsBackgroundWorkerfromUserMetaData, use Firebase background common executor for user metadata logging such as user id, custom key value, internal key value and rollouts.Test:
Checking with log and see key data is writing from different Firebase background common thread
Also same unit test is tested on current implementation with Crashlytics Background Worker. Current way of doing it is actually less efficient since everything is run on the same Junit Test Thread, every iteration of change it need to update the writes to disk (where as the new implementation log you can see we skipped a lot writing entry):
