Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade datastore-preferences in AQS #6079

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Upgrade datastore-preferences in AQS #6079

wants to merge 4 commits into from

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Jul 4, 2024

Upgrade datastore-preferences in AQS to 1.1.1, which supports multi-process apps accessing the same file. This let us remove the process name from the file name, which means all processes can share one copy of the settings. This will reduce the network traffic, and let the sdk be lighter.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Release note changes

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

firebase-sessions

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Unit Test Results

     950 files  ±0       950 suites  ±0   34m 56s ⏱️ -16s
  5 210 tests  - 1    5 189 ✔️  - 1  21 💤 ±0  0 ±0 
10 505 runs   - 2  10 463 ✔️  - 2  42 💤 ±0  0 ±0 

Results for commit 99d281f. ± Comparison against base commit 58540de.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (58540de)Merge (fd8764c)Diff
    apk (aggressive)688 kB511 kB-177 kB (-25.8%)
    apk (release)5.84 MB6.27 MB+431 kB (+7.4%)
  • firebase-crashlytics-ktx

    TypeBase (58540de)Merge (fd8764c)Diff
    apk (aggressive)689 kB511 kB-177 kB (-25.7%)
    apk (release)5.84 MB6.27 MB+431 kB (+7.4%)
  • firebase-crashlytics-ndk

    TypeBase (58540de)Merge (fd8764c)Diff
    apk (aggressive / arm64-v8a)1.86 MB1.68 MB-177 kB (-9.5%)
    apk (aggressive / armeabi-v7a)1.34 MB1.16 MB-177 kB (-13.2%)
    apk (aggressive / x86)1.84 MB1.66 MB-177 kB (-9.6%)
    apk (aggressive / x86_64)1.90 MB1.73 MB-177 kB (-9.3%)
    apk (release / arm64-v8a)7.01 MB7.44 MB+434 kB (+6.2%)
    apk (release / armeabi-v7a)6.48 MB6.92 MB+434 kB (+6.7%)
    apk (release / x86)6.98 MB7.42 MB+434 kB (+6.2%)
    apk (release / x86_64)7.05 MB7.48 MB+434 kB (+6.2%)
  • firebase-sessions

    TypeBase (58540de)Merge (fd8764c)Diff
    aar168 kB167 kB-1.11 kB (-0.7%)
    apk (aggressive)556 kB371 kB-185 kB (-33.2%)
    apk (release)5.53 MB5.96 MB+431 kB (+7.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9yjp0M3Lqu.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-ml-modeldownloader

    Overall coverage changed from 83.32% (58540de) to 83.38% (fd8764c) by +0.06%.

    FilenameBase (58540de)Merge (fd8764c)Diff
    FirebaseModelDownloader.java84.05%84.66%+0.61%
  • firebase-storage

    Overall coverage changed from 84.08% (58540de) to 84.12% (fd8764c) by +0.04%.

    FilenameBase (58540de)Merge (fd8764c)Diff
    NetworkRequest.java87.29%87.85%+0.55%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vao8bkLTea.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants