Upgrade Crashlytics dep versions #6083

mrober · 2024-07-08T19:10:39Z

Update Crashlytics and AQS dep versions. Fixed some of the tests because of changes to Mockito. The Mockito version in the Android tests is still pinned a bit old, because after that version a lot more things break.

github-actions · 2024-07-08T19:10:50Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2024-07-08T19:17:08Z

Coverage Report ¹

Affected Products

`firebase-crashlytics`

Overall coverage changed from 10.35% (d48cb12) to 10.16% (9f7a777) by -0.19%.

Filename	Base (`d48cb12`)	Merge (`9f7a777`)	Diff
AutoValue_CrashlyticsReport_ApplicationExitInfo.java	66.34%	58.42%	-7.92%
AutoValue_CrashlyticsReport_Session_Event_Application_ProcessDetails.java	49.12%	40.35%	-8.77%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/veTiWdeajc.html

google-oss-bot · 2024-07-08T19:22:05Z

Size Report ¹

Affected Products

firebase-crashlytics
Type Base (d48cb12) Merge (9f7a777) Diff
aar 409 kB 408 kB -1.16 kB (-0.3%)
apk (aggressive) 688 kB 695 kB +6.63 kB (+1.0%)
apk (release) 5.84 MB 5.84 MB -2.19 kB (-0.0%)
firebase-sessions
Type Base (d48cb12) Merge (9f7a777) Diff
apk (aggressive) 556 kB 560 kB +3.63 kB (+0.7%)
apk (release) 5.53 MB 5.52 MB -5.91 kB (-0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/f556ZidRpO.html

github-actions · 2024-07-08T19:24:04Z

Unit Test Results

  36 files -     914   36 suites - 914 1m 10s ⏱️ - 33m 50s
  92 tests -   5 119   92 ✔️ -   5 098 0 💤 - 21 0 ❌ ±0
184 runs - 10 323 184 ✔️ - 10 281 0 💤 - 42 0 ❌ ±0

Results for commit 47d4389. ± Comparison against base commit d48cb12.

google-oss-bot · 2024-07-08T19:42:01Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (d48cb12) and the CI merge commit (9f7a777)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- d48cb12: https://storage.googleapis.com/firebase-sdk-metric-reports/O3xm29f34G/index.html
- 9f7a777: https://storage.googleapis.com/firebase-sdk-metric-reports/lU6XGi4Nvx/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`d48cb12`	`9f7a777`	Diff	Significant (?)
p10	11.0 ±3 ms	10.6 ±3 ms	-405 μs (-3.7%)	NO
p25	11.7 ±3 ms	11.1 ±3 ms	-535 μs (-4.6%)	NO
p50	12.6 ±3 ms	12.1 ±3 ms	-566 μs (-4.5%)	NO
p75	13.9 ±3 ms	13.4 ±3 ms	-471 μs (-3.4%)	NO
p90	15.3 ±3 ms	15.0 ±3 ms	-355 μs (-2.3%)	NO

20 test runs in comparison

Commit	Test Runs
`d48cb12`	2024-07-05_17:58:55.930065_ZmRX 2024-07-05_17:58:55.930110_okrn 2024-07-05_17:58:55.930120_JqLO 2024-07-05_17:58:55.930130_rHcp 2024-07-05_17:58:55.930138_rmjP 2024-07-05_17:58:55.930145_onLA 2024-07-05_17:58:55.930152_tgCo 2024-07-05_17:58:55.930160_kVxY 2024-07-05_17:58:55.930168_BXmn 2024-07-05_17:58:55.930175_MJYJ
`9f7a777`	2024-07-08_19:24:08.611776_wuIM 2024-07-08_19:24:08.611869_XhZL 2024-07-08_19:24:08.611884_aNJX 2024-07-08_19:24:08.611893_Kdmx 2024-07-08_19:24:08.611900_jAOc 2024-07-08_19:24:08.611907_fELp 2024-07-08_19:24:08.611925_Xzth 2024-07-08_19:24:08.611932_pPrN 2024-07-08_19:24:08.611938_JdYx 2024-07-08_19:24:08.611945_RAMy

redfin-30

Percentile	`d48cb12`	`9f7a777`	Diff	Significant (?)
p10	14.4 ±5 ms	15.9 ±6 ms	+1.46 ms (+10.1%)	NO
p25	15.1 ±6 ms	16.8 ±7 ms	+1.64 ms (+10.8%)	NO
p50	16.0 ±7 ms	18.0 ±7 ms	+2.00 ms (+12.6%)	NO
p75	17.0 ±7 ms	19.6 ±9 ms	+2.63 ms (+15.5%)	NO
p90	18.7 ±8 ms	21.9 ±9 ms	+3.21 ms (+17.2%)	NO

20 test runs in comparison

Commit	Test Runs
`d48cb12`	2024-07-05_17:58:55.930065_ZmRX 2024-07-05_17:58:55.930110_okrn 2024-07-05_17:58:55.930120_JqLO 2024-07-05_17:58:55.930130_rHcp 2024-07-05_17:58:55.930138_rmjP 2024-07-05_17:58:55.930145_onLA 2024-07-05_17:58:55.930152_tgCo 2024-07-05_17:58:55.930160_kVxY 2024-07-05_17:58:55.930168_BXmn 2024-07-05_17:58:55.930175_MJYJ
`9f7a777`	2024-07-08_19:24:08.611776_wuIM 2024-07-08_19:24:08.611869_XhZL 2024-07-08_19:24:08.611884_aNJX 2024-07-08_19:24:08.611893_Kdmx 2024-07-08_19:24:08.611900_jAOc 2024-07-08_19:24:08.611907_fELp 2024-07-08_19:24:08.611925_Xzth 2024-07-08_19:24:08.611932_pPrN 2024-07-08_19:24:08.611938_JdYx 2024-07-08_19:24:08.611945_RAMy

`fire-rc`

Device Statistics Distributions

oriole-32

Percentile	`d48cb12`	`9f7a777`	Diff	Significant (?)
p10	470 ±548 μs	209 ±299 μs	-261 μs (-55.6%)	NO
p25	490 ±567 μs	220 ±316 μs	-270 μs (-55.0%)	NO
p50	523 ±595 μs	244 ±355 μs	-279 μs (-53.3%)	NO
p75	590 ±667 μs	290 ±407 μs	-300 μs (-50.8%)	NO
p90	732 ±779 μs	349 ±494 μs	-383 μs (-52.3%)	NO

20 test runs in comparison

Commit	Test Runs
`d48cb12`	2024-07-05_17:58:55.930065_ZmRX 2024-07-05_17:58:55.930110_okrn 2024-07-05_17:58:55.930120_JqLO 2024-07-05_17:58:55.930130_rHcp 2024-07-05_17:58:55.930138_rmjP 2024-07-05_17:58:55.930145_onLA 2024-07-05_17:58:55.930152_tgCo 2024-07-05_17:58:55.930160_kVxY 2024-07-05_17:58:55.930168_BXmn 2024-07-05_17:58:55.930175_MJYJ
`9f7a777`	2024-07-08_19:24:08.611776_wuIM 2024-07-08_19:24:08.611869_XhZL 2024-07-08_19:24:08.611884_aNJX 2024-07-08_19:24:08.611893_Kdmx 2024-07-08_19:24:08.611900_jAOc 2024-07-08_19:24:08.611907_fELp 2024-07-08_19:24:08.611925_Xzth 2024-07-08_19:24:08.611932_pPrN 2024-07-08_19:24:08.611938_JdYx 2024-07-08_19:24:08.611945_RAMy

redfin-30

Percentile	`d48cb12`	`9f7a777`	Diff	Significant (?)
p10	213 ±132 μs	530 ±623 μs	+317 μs (+149.3%)	NO
p25	237 ±178 μs	629 ±759 μs	+392 μs (+165.9%)	NO
p50	289 ±290 μs	737 ±882 μs	+448 μs (+155.2%)	NO
p75	358 ±408 μs	897 ±1082 μs	+539 μs (+150.8%)	NO
p90	474 ±498 μs	1.10 ±1 ms	+629 μs (+132.7%)	NO

20 test runs in comparison

Commit	Test Runs
`d48cb12`	2024-07-05_17:58:55.930065_ZmRX 2024-07-05_17:58:55.930110_okrn 2024-07-05_17:58:55.930120_JqLO 2024-07-05_17:58:55.930130_rHcp 2024-07-05_17:58:55.930138_rmjP 2024-07-05_17:58:55.930145_onLA 2024-07-05_17:58:55.930152_tgCo 2024-07-05_17:58:55.930160_kVxY 2024-07-05_17:58:55.930168_BXmn 2024-07-05_17:58:55.930175_MJYJ
`9f7a777`	2024-07-08_19:24:08.611776_wuIM 2024-07-08_19:24:08.611869_XhZL 2024-07-08_19:24:08.611884_aNJX 2024-07-08_19:24:08.611893_Kdmx 2024-07-08_19:24:08.611900_jAOc 2024-07-08_19:24:08.611907_fELp 2024-07-08_19:24:08.611925_Xzth 2024-07-08_19:24:08.611932_pPrN 2024-07-08_19:24:08.611938_JdYx 2024-07-08_19:24:08.611945_RAMy

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`d48cb12`	`9f7a777`	Diff	Significant (?)
p10	2.65 ±0.3 ms	2.82 ±0.5 ms	+173 μs (+6.5%)	NO
p25	2.83 ±0.4 ms	3.02 ±0.5 ms	+181 μs (+6.4%)	NO
p50	3.17 ±0.5 ms	3.40 ±0.7 ms	+229 μs (+7.2%)	NO
p75	3.63 ±0.5 ms	3.90 ±0.8 ms	+268 μs (+7.4%)	NO
p90	4.46 ±0.9 ms	4.77 ±1 ms	+311 μs (+7.0%)	NO

20 test runs in comparison

Commit	Test Runs
`d48cb12`	2024-07-05_17:58:55.930065_ZmRX 2024-07-05_17:58:55.930110_okrn 2024-07-05_17:58:55.930120_JqLO 2024-07-05_17:58:55.930130_rHcp 2024-07-05_17:58:55.930138_rmjP 2024-07-05_17:58:55.930145_onLA 2024-07-05_17:58:55.930152_tgCo 2024-07-05_17:58:55.930160_kVxY 2024-07-05_17:58:55.930168_BXmn 2024-07-05_17:58:55.930175_MJYJ
`9f7a777`	2024-07-08_19:24:08.611776_wuIM 2024-07-08_19:24:08.611869_XhZL 2024-07-08_19:24:08.611884_aNJX 2024-07-08_19:24:08.611893_Kdmx 2024-07-08_19:24:08.611900_jAOc 2024-07-08_19:24:08.611907_fELp 2024-07-08_19:24:08.611925_Xzth 2024-07-08_19:24:08.611932_pPrN 2024-07-08_19:24:08.611938_JdYx 2024-07-08_19:24:08.611945_RAMy

redfin-30

Percentile	`d48cb12`	`9f7a777`	Diff	Significant (?)
p10	6.31 ±2 ms	6.47 ±2 ms	+164 μs (+2.6%)	NO
p25	6.81 ±2 ms	7.05 ±2 ms	+241 μs (+3.5%)	NO
p50	7.48 ±3 ms	7.99 ±3 ms	+509 μs (+6.8%)	NO
p75	8.44 ±4 ms	9.53 ±5 ms	+1.08 ms (+12.8%)	NO
p90	9.43 ±5 ms	10.9 ±6 ms	+1.50 ms (+15.9%)	NO

20 test runs in comparison

Commit	Test Runs
`d48cb12`	2024-07-05_17:58:55.930065_ZmRX 2024-07-05_17:58:55.930110_okrn 2024-07-05_17:58:55.930120_JqLO 2024-07-05_17:58:55.930130_rHcp 2024-07-05_17:58:55.930138_rmjP 2024-07-05_17:58:55.930145_onLA 2024-07-05_17:58:55.930152_tgCo 2024-07-05_17:58:55.930160_kVxY 2024-07-05_17:58:55.930168_BXmn 2024-07-05_17:58:55.930175_MJYJ
`9f7a777`	2024-07-08_19:24:08.611776_wuIM 2024-07-08_19:24:08.611869_XhZL 2024-07-08_19:24:08.611884_aNJX 2024-07-08_19:24:08.611893_Kdmx 2024-07-08_19:24:08.611900_jAOc 2024-07-08_19:24:08.611907_fELp 2024-07-08_19:24:08.611925_Xzth 2024-07-08_19:24:08.611932_pPrN 2024-07-08_19:24:08.611938_JdYx 2024-07-08_19:24:08.611945_RAMy

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`d48cb12`	`9f7a777`	Diff	Significant (?)
p10	202 ±5 ms	208 ±3 ms	+5.89 ms (+2.9%)	NO
p25	208 ±5 ms	213 ±3 ms	+4.93 ms (+2.4%)	NO
p50	216 ±6 ms	220 ±4 ms	+4.65 ms (+2.2%)	NO
p75	223 ±7 ms	229 ±4 ms	+5.61 ms (+2.5%)	NO
p90	231 ±7 ms	239 ±5 ms	+7.45 ms (+3.2%)	NO

20 test runs in comparison

Commit	Test Runs
`d48cb12`	2024-07-05_17:58:55.930065_ZmRX 2024-07-05_17:58:55.930110_okrn 2024-07-05_17:58:55.930120_JqLO 2024-07-05_17:58:55.930130_rHcp 2024-07-05_17:58:55.930138_rmjP 2024-07-05_17:58:55.930145_onLA 2024-07-05_17:58:55.930152_tgCo 2024-07-05_17:58:55.930160_kVxY 2024-07-05_17:58:55.930168_BXmn 2024-07-05_17:58:55.930175_MJYJ
`9f7a777`	2024-07-08_19:24:08.611776_wuIM 2024-07-08_19:24:08.611869_XhZL 2024-07-08_19:24:08.611884_aNJX 2024-07-08_19:24:08.611893_Kdmx 2024-07-08_19:24:08.611900_jAOc 2024-07-08_19:24:08.611907_fELp 2024-07-08_19:24:08.611925_Xzth 2024-07-08_19:24:08.611932_pPrN 2024-07-08_19:24:08.611938_JdYx 2024-07-08_19:24:08.611945_RAMy

redfin-30

Percentile	`d48cb12`	`9f7a777`	Diff	Significant (?)
p10	241 ±2 ms	267 ±6 ms	+25.8 ms (+10.7%)	MAYBE
p25	246 ±2 ms	273 ±5 ms	+26.7 ms (+10.8%)	YES
p50	253 ±3 ms	280 ±5 ms	+26.7 ms (+10.6%)	YES
p75	260 ±3 ms	287 ±5 ms	+27.5 ms (+10.6%)	YES
p90	269 ±4 ms	301 ±7 ms	+32.5 ms (+12.1%)	YES

20 test runs in comparison

Commit	Test Runs
`d48cb12`	2024-07-05_17:58:55.930065_ZmRX 2024-07-05_17:58:55.930110_okrn 2024-07-05_17:58:55.930120_JqLO 2024-07-05_17:58:55.930130_rHcp 2024-07-05_17:58:55.930138_rmjP 2024-07-05_17:58:55.930145_onLA 2024-07-05_17:58:55.930152_tgCo 2024-07-05_17:58:55.930160_kVxY 2024-07-05_17:58:55.930168_BXmn 2024-07-05_17:58:55.930175_MJYJ
`9f7a777`	2024-07-08_19:24:08.611776_wuIM 2024-07-08_19:24:08.611869_XhZL 2024-07-08_19:24:08.611884_aNJX 2024-07-08_19:24:08.611893_Kdmx 2024-07-08_19:24:08.611900_jAOc 2024-07-08_19:24:08.611907_fELp 2024-07-08_19:24:08.611925_Xzth 2024-07-08_19:24:08.611932_pPrN 2024-07-08_19:24:08.611938_JdYx 2024-07-08_19:24:08.611945_RAMy

https://storage.googleapis.com/firebase-sdk-metric-reports/wlkwfVC2Ts/index.html

themiswang

LGTM

Upgrade Crashlytics dep versions

47d4389

mrober added no-changelog main-merge-ack labels Jul 8, 2024

google-oss-bot added the size/M label Jul 8, 2024

mrober requested a review from themiswang July 8, 2024 19:56

mrober enabled auto-merge (squash) July 8, 2024 19:56

themiswang approved these changes Jul 8, 2024

View reviewed changes

mrober merged commit ec68af6 into main Jul 8, 2024
37 checks passed

mrober deleted the crashlytics-deps-bump branch July 8, 2024 20:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Crashlytics dep versions #6083

Upgrade Crashlytics dep versions #6083

mrober commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

google-oss-bot commented Jul 8, 2024

`firebase-crashlytics`

google-oss-bot commented Jul 8, 2024

`firebase-crashlytics`

`firebase-sessions`

github-actions bot commented Jul 8, 2024

google-oss-bot commented Jul 8, 2024

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`

themiswang left a comment

Upgrade Crashlytics dep versions #6083

Upgrade Crashlytics dep versions #6083

Conversation

mrober commented Jul 8, 2024 • edited Loading

github-actions bot commented Jul 8, 2024 • edited Loading

📝 PRs merging into main branch

google-oss-bot commented Jul 8, 2024

Coverage Report 1

Affected Products

firebase-crashlytics

Test Logs

google-oss-bot commented Jul 8, 2024

Size Report 1

Affected Products

firebase-crashlytics

firebase-sessions

Test Logs

github-actions bot commented Jul 8, 2024

Unit Test Results

google-oss-bot commented Jul 8, 2024

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-rc

fire-sessions

timeToInitialDisplay

themiswang left a comment

Choose a reason for hiding this comment

mrober commented Jul 8, 2024 •

edited

Loading

github-actions bot commented Jul 8, 2024 •

edited

Loading

Coverage Report ¹

`firebase-crashlytics`

Size Report ¹

`firebase-crashlytics`

`firebase-sessions`

Startup Time Report ¹

`fire-cls`

`fire-rc`

`fire-sessions`

`timeToInitialDisplay`