Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call HeartbeatController.LogHeartbeat from Auth's desktop implementation #1056

Conversation

AlmostMatt
Copy link
Contributor

Description

Update the LogHeartbeat method in auth_desktop to get an instance of HeartbeatController and call LogHeartbeat on that controller.
This PR also adds a static map from app_name to HeartbeatController instances and a static method to get such an instance. This is defined in app_desktop.h and implemented in app_desktop.cc
This PR creates app_desktop.h and moves an existing class definition from app_desktop.cc to app_desktop.h


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Verified via unit test that by calling the static method in AppDesktop that a functional instance of HeartbeatController
Will manually perform end to end testing after code to add payload to auth requests is completed.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • [ x] Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

…e app_desktop header to contain this and other existing app_desktop code
@AlmostMatt AlmostMatt marked this pull request as draft August 12, 2022 15:29
@AlmostMatt AlmostMatt marked this pull request as ready for review August 12, 2022 17:30
app/src/include/firebase/app.h Outdated Show resolved Hide resolved
auth/src/desktop/auth_desktop.cc Outdated Show resolved Hide resolved
app/src/include/firebase/app.h Outdated Show resolved Hide resolved
@AlmostMatt AlmostMatt merged commit c357d00 into almostmatt-heartbeat-implementation2 Aug 29, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Aug 29, 2022
@github-actions
Copy link

github-actions bot commented Aug 29, 2022

Integration test with FLAKINESS (succeeded after retry)

Requested by @AlmostMatt on commit c357d00
Last updated: Mon Aug 29 20:30 PDT 2022
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseAuthTest.TestUpdateEmailAndPassword
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation
storage [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 30, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 30, 2022
@firebase firebase locked and limited conversation to collaborators Sep 29, 2022
@AlmostMatt AlmostMatt deleted the almostmatt-heartbeat-desktop-integration branch October 20, 2022 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants