-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call HeartbeatController.LogHeartbeat from Auth's desktop implementation #1056
Merged
AlmostMatt
merged 10 commits into
almostmatt-heartbeat-implementation2
from
almostmatt-heartbeat-desktop-integration
Aug 29, 2022
Merged
Call HeartbeatController.LogHeartbeat from Auth's desktop implementation #1056
AlmostMatt
merged 10 commits into
almostmatt-heartbeat-implementation2
from
almostmatt-heartbeat-desktop-integration
Aug 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e app_desktop header to contain this and other existing app_desktop code
…nal. Add methods to interact with this in App guarded by ifdef EXPERIMENTAL_INTERNAL
…to local variable
…o make use of the per-app HeartbeatController
chkuang-g
reviewed
Aug 15, 2022
chkuang-g
requested changes
Aug 29, 2022
chkuang-g
approved these changes
Aug 29, 2022
github-actions
bot
added
the
tests: in-progress
This PR's integration tests are in progress.
label
Aug 29, 2022
Integration test with FLAKINESS (succeeded after retry)Requested by @AlmostMatt on commit c357d00
Add flaky tests to go/fpl-cpp-flake-tracker |
github-actions
bot
added
the
tests: succeeded
This PR's integration tests succeeded.
label
Aug 30, 2022
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the LogHeartbeat method in auth_desktop to get an instance of HeartbeatController and call LogHeartbeat on that controller.
This PR also adds a static map from app_name to HeartbeatController instances and a static method to get such an instance. This is defined in app_desktop.h and implemented in app_desktop.cc
This PR creates app_desktop.h and moves an existing class definition from app_desktop.cc to app_desktop.h
Testing
Verified via unit test that by calling the static method in AppDesktop that a functional instance of HeartbeatController
Will manually perform end to end testing after code to add payload to auth requests is completed.
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.