Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error TS2305: Module '"./common/manifest"' has no exported member 'ManifestEndpoint' #1031

Closed
pprachit09 opened this issue Feb 4, 2022 · 8 comments · Fixed by #1032 or #1033
Closed

Comments

@pprachit09
Copy link

After updating firebase-functions to 3.17.0, I am facing an issue while deploying the changes.

firebase deploy --only functions

node_modules/firebase-functions/lib/cloud-functions.d.ts(5,10): error TS2305: Module '"./common/manifest"' has no exported member 'ManifestEndpoint'. node_modules/firebase-functions/lib/cloud-functions.d.ts(5,28): error TS2305: Module '"./common/manifest"' has no exported member 'ManifestRequiredAPI'. node_modules/firebase-functions/lib/providers/https.d.ts(3,10): error TS2305: Module '"../common/manifest"' has no exported member 'ManifestEndpoint'. node_modules/firebase-functions/lib/providers/https.d.ts(3,28): error TS2305: Module '"../common/manifest"' has no exported member 'ManifestRequiredAPI'.

Reverting back to 3.16.0 in package.json resolves the issue for me.

@google-oss-bot
Copy link
Collaborator

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@Zelfapp
Copy link

Zelfapp commented Feb 4, 2022

Same issue after upgrading to 3.17.0 when running firebase deploy --only functions

Had to rollback firebase-functions in package.json to force 3.16.0 and run npm update

"firebase-functions": "3.16.0"
node_modules/firebase-functions/lib/cloud-functions.d.ts:5:10 - error TS2305: Module '"./common/manifest"' has no exported member 'ManifestEndpoint'.

5 import { ManifestEndpoint, ManifestRequiredAPI } from './common/manifest';
           ~~~~~~~~~~~~~~~~

node_modules/firebase-functions/lib/cloud-functions.d.ts:5:28 - error TS2305: Module '"./common/manifest"' has no exported member 'ManifestRequiredAPI'.

5 import { ManifestEndpoint, ManifestRequiredAPI } from './common/manifest';
                             ~~~~~~~~~~~~~~~~~~~

node_modules/firebase-functions/lib/providers/https.d.ts:3:10 - error TS2305: Module '"../common/manifest"' has no exported member 'ManifestEndpoint'.

3 import { ManifestEndpoint, ManifestRequiredAPI } from '../common/manifest';
           ~~~~~~~~~~~~~~~~

node_modules/firebase-functions/lib/providers/https.d.ts:3:28 - error TS2305: Module '"../common/manifest"' has no exported member 'ManifestRequiredAPI'.

3 import { ManifestEndpoint, ManifestRequiredAPI } from '../common/manifest';

@taeold
Copy link
Contributor

taeold commented Feb 4, 2022

Thanks for the report and sorry for the troubles.

The hotfix is underway.

@taeold
Copy link
Contributor

taeold commented Feb 4, 2022

Release 3.17.1 should contain the fix for the reported issue. Please let us know if you are facing any other issue!

@Blunderchips
Copy link

Working now for me

@IchordeDionysos
Copy link

IchordeDionysos commented Feb 6, 2022

I'm still having this error:

node_modules/firebase-functions/lib/v2/core.d.ts:1:10 - error TS2305: Module '"../runtime/manifest"' has no exported member 'ManifestEndpoint'.

1 import { ManifestEndpoint } from '../runtime/manifest';
           ~~~~~~~~~~~~~~~~

node_modules/firebase-functions/lib/v2/providers/https.d.ts:4:10 - error TS2305: Module '"../../runtime/manifest"' has no exported member 'ManifestEndpoint'.

4 import { ManifestEndpoint } from '../../runtime/manifest';
           ~~~~~~~~~~~~~~~~

EDIT: Fixed in 3.17.2

@guillaumeprevost
Copy link

Thanks @taeold !
Updated to 3.17.1 and seems to fix it, both locally and in my CI pipeline

taeold added a commit that referenced this issue Feb 7, 2022
…#1033)

Follows up #1032 for V2 API to fix #1031.

While rebasing the branch that moved the location of manifest definition (#1003), the original file was not removed and cleaned up. Having long-lasting PR is dangeroud 🤦🏼‍♂️ .
@creativecreatorormaybenot

@IchordeDionysos That does look like a different error because the module in question in this issue is common/manifest rather than runtime/manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment