Unbreak v2 TS users by safely removing duplicated manifest definition (…

…#1033)

Follows up #1032 for V2 API to fix #1031.

While rebasing the branch that moved the location of manifest definition (#1003), the original file was not removed and cleaned up. Having long-lasting PR is dangeroud 🤦🏼‍♂️ .

CHANGELOG.md

@@ -0,0 +1 @@
+- Fix issue where v2 TS users couldn't compile their code because of unexported types. (#1033)

src/cloud-functions.ts

@@ -37,7 +37,7 @@ import {
   durationFromSeconds,
   serviceAccountFromShorthand,
 } from './common/encoding';
-import { ManifestEndpoint, ManifestRequiredAPI } from './common/manifest';
+import { ManifestEndpoint, ManifestRequiredAPI } from './runtime/manifest';
 
 /** @hidden */
 const WILDCARD_REGEX = new RegExp('{[^/{}]*}', 'g');

src/providers/https.ts

@@ -33,7 +33,7 @@ import {
   convertInvoker,
   copyIfPresent,
 } from '../common/encoding';
-import { ManifestEndpoint, ManifestRequiredAPI } from '../common/manifest';
+import { ManifestEndpoint, ManifestRequiredAPI } from '../runtime/manifest';
 import {
   CallableContext,
   FunctionsErrorCode,

src/runtime/manifest.ts

@@ -20,7 +20,6 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 /**
- * @internal
  * An definition of a function as appears in the Manifest.
  */
 export interface ManifestEndpoint {
@@ -68,14 +67,12 @@ export interface ManifestEndpoint {
   };
 }
 
-/* @internal */
 export interface ManifestRequiredAPI {
   api: string;
   reason: string;
 }
 
 /**
- * @internal
  * An definition of a function deployment as appears in the Manifest.
  **/
 export interface ManifestStack {

src/v2/providers/alerts/alerts.ts

@@ -1,4 +1,4 @@
-import { ManifestEndpoint } from '../../../common/manifest';
+import { ManifestEndpoint } from '../../../runtime/manifest';
 import { CloudEvent, CloudFunction } from '../../core';
 import * as options from '../../options';