Skip to content

Commit

Permalink
Delete duplicate function (#4744) (#4748)
Browse files Browse the repository at this point in the history
Co-authored-by: Paul Beusterien <paulbeusterien@google.com>
  • Loading branch information
maksymmalyhin and paulb777 committed Jan 24, 2020
1 parent 30c6197 commit b890b1c
Show file tree
Hide file tree
Showing 14 changed files with 15 additions and 66 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

@class FIRInAppMessagingBannerDisplay;
@class FIRIAMBaseRenderingViewController;
@protocol FIDTimeFetcher;
@protocol FIRIAMTimeFetcher;
@protocol FIRInAppMessagingDisplayDelegate;

NS_ASSUME_NONNULL_BEGIN
Expand All @@ -30,6 +30,6 @@ NS_ASSUME_NONNULL_BEGIN
displayMessage:(FIRInAppMessagingBannerDisplay *)bannerMessage
displayDelegate:
(id<FIRInAppMessagingDisplayDelegate>)displayDelegate
timeFetcher:(id<FIDTimeFetcher>)timeFetcher;
timeFetcher:(id<FIRIAMTimeFetcher>)timeFetcher;
@end
NS_ASSUME_NONNULL_END
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ @implementation FIRIAMBannerViewController
displayMessage:(FIRInAppMessagingBannerDisplay *)bannerMessage
displayDelegate:
(id<FIRInAppMessagingDisplayDelegate>)displayDelegate
timeFetcher:(id<FIDTimeFetcher>)timeFetcher {
timeFetcher:(id<FIRIAMTimeFetcher>)timeFetcher {
UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"FIRInAppMessageDisplayStoryboard"
bundle:resourceBundle];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ NS_ASSUME_NONNULL_BEGIN
displayMessage:(FIRInAppMessagingCardDisplay *)cardMessage
displayDelegate:
(id<FIRInAppMessagingDisplayDelegate>)displayDelegate
timeFetcher:(id<FIDTimeFetcher>)timeFetcher;
timeFetcher:(id<FIRIAMTimeFetcher>)timeFetcher;

@end
NS_ASSUME_NONNULL_END
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ @implementation FIRIAMCardViewController
displayMessage:(FIRInAppMessagingCardDisplay *)cardMessage
displayDelegate:
(id<FIRInAppMessagingDisplayDelegate>)displayDelegate
timeFetcher:(id<FIDTimeFetcher>)timeFetcher {
timeFetcher:(id<FIRIAMTimeFetcher>)timeFetcher {
UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"FIRInAppMessageDisplayStoryboard"
bundle:resourceBundle];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
#import <UIKit/UIKit.h>

#import <FirebaseInAppMessaging/FIRInAppMessagingRendering.h>
#import "FIDTimeFetcher.h"
#import "FIRIAMTimeFetcher.h"

@protocol FIRInAppMessagingDisplayDelegate;

NS_ASSUME_NONNULL_BEGIN
@interface FIRIAMBaseRenderingViewController : UIViewController
@property(nonatomic, readwrite) id<FIDTimeFetcher> timeFetcher;
@property(nonatomic, readwrite) id<FIRIAMTimeFetcher> timeFetcher;

@property(nonatomic, readwrite) id<FIRInAppMessagingDisplayDelegate> displayDelegate;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*/

#import "FIRIAMBaseRenderingViewController.h"
#import "FIDTimeFetcher.h"
#import "FIRCore+InAppMessagingDisplay.h"
#import "FIRIAMTimeFetcher.h"

@interface FIRIAMBaseRenderingViewController ()
// For fiam messages, it's required to be kMinValidImpressionTime to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@

#import <FirebaseInAppMessaging/FIRInAppMessaging.h>
#import <FirebaseInAppMessaging/FIRInAppMessagingRendering.h>
#import "FIDTimeFetcher.h"
#import "FIRCore+InAppMessagingDisplay.h"
#import "FIRIAMBannerViewController.h"
#import "FIRIAMCardViewController.h"
#import "FIRIAMDefaultDisplayImpl.h"
#import "FIRIAMImageOnlyViewController.h"
#import "FIRIAMModalViewController.h"
#import "FIRIAMRenderingWindowHelper.h"
#import "FIRIAMTimeFetcher.h"

@implementation FIRIAMDefaultDisplayImpl

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#import "FIRIAMBaseRenderingViewController.h"

@class FIRInAppMessagingImageOnlyDisplay;
@protocol FIDTimeFetcher;
@protocol FIRIAMTimeFetcher;
@protocol FIRInAppMessagingDisplayDelegate;

NS_ASSUME_NONNULL_BEGIN
Expand All @@ -30,6 +30,6 @@ NS_ASSUME_NONNULL_BEGIN
(FIRInAppMessagingImageOnlyDisplay *)imageOnlyMessage
displayDelegate:
(id<FIRInAppMessagingDisplayDelegate>)displayDelegate
timeFetcher:(id<FIDTimeFetcher>)timeFetcher;
timeFetcher:(id<FIRIAMTimeFetcher>)timeFetcher;
@end
NS_ASSUME_NONNULL_END
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ @implementation FIRIAMImageOnlyViewController
(FIRInAppMessagingImageOnlyDisplay *)imageOnlyMessage
displayDelegate:
(id<FIRInAppMessagingDisplayDelegate>)displayDelegate
timeFetcher:(id<FIDTimeFetcher>)timeFetcher {
timeFetcher:(id<FIRIAMTimeFetcher>)timeFetcher {
UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"FIRInAppMessageDisplayStoryboard"
bundle:resourceBundle];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ NS_ASSUME_NONNULL_BEGIN
displayMessage:(FIRInAppMessagingModalDisplay *)modalMessage
displayDelegate:
(id<FIRInAppMessagingDisplayDelegate>)displayDelegate
timeFetcher:(id<FIDTimeFetcher>)timeFetcher;
timeFetcher:(id<FIRIAMTimeFetcher>)timeFetcher;
@end
NS_ASSUME_NONNULL_END
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ @implementation FIRIAMModalViewController
displayMessage:(FIRInAppMessagingModalDisplay *)modalMessage
displayDelegate:
(id<FIRInAppMessagingDisplayDelegate>)displayDelegate
timeFetcher:(id<FIDTimeFetcher>)timeFetcher {
timeFetcher:(id<FIRIAMTimeFetcher>)timeFetcher {
UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"FIRInAppMessageDisplayStoryboard"
bundle:resourceBundle];

Expand Down
28 changes: 0 additions & 28 deletions FirebaseInAppMessaging/Sources/DefaultUI/Util/FIDTimeFetcher.h

This file was deleted.

23 changes: 0 additions & 23 deletions FirebaseInAppMessaging/Sources/DefaultUI/Util/FIDTimeFetcher.m

This file was deleted.

2 changes: 1 addition & 1 deletion scripts/if_changed.sh
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ else
;;

InAppMessaging-*)
check_changes '^(InAppMessaging|Firebase/InAppMessaging|Firebase/InAppMessagingDisplay|InAppMessagingDisplay|'\
check_changes '^(FirebaseInAppMessaging|FirebaseInAppMessagingDisplay|'\
'FirebaseInAppMessaging.podspec|FirebaseInAppMessagingDisplay.podspec|Firebase/InstanceID|FirebaseInstanceID.podspec|'\
'FirebaseInstallations)'
;;
Expand Down

0 comments on commit b890b1c

Please sign in to comment.