-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: Make Crashlytics upload-symbols
compatible with visionOS
#12306
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
I would like to contribute for this but could not figure out how to edit the binary |
Hey @treastrain, Thank you for the detailed description! We are not introducing platform specific behaviour and the platform flag is actually not used on our backend. Using |
Hi Anya, Thanks for replying! And I'm sorry I didn't search well and couldn't get to #11515. I'm unable to become an initial purchaser of the Apple Vision Pro because I live in Japan... I would like to follow the progress of this, thanks to the help of its contributors! |
@themiswang it would be great to have the docs updated, I'm facing the same exact issue as above: Adding error here so ppl will easily found a solution from the SERP.
At the end the workaround for # Define variables
GOOGLE_PLIST_PATH="${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/GoogleService-Info.plist"
DSYM_PATH="${DWARF_DSYM_FOLDER_PATH}/${DWARF_DSYM_FILE_NAME}"
PLATFORM_NAME="ios" # xros is not yet supported
# Specify path to upload-symbols script
UPLOAD_SYMBOLS_SCRIPT="${BUILD_DIR%/Build/*}/SourcePackages/checkouts/firebase-ios-sdk/Crashlytics/upload-symbols"
# Execute upload-symbols script
"${UPLOAD_SYMBOLS_SCRIPT}" -gsp "${GOOGLE_PLIST_PATH}" -p "${PLATFORM_NAME}" "${DSYM_PATH}" |
People of Google. Could you please take a look at the issue? It looks like 1 human hour job to support a new platform for you (because visionOS is the sister of iPadOS, all should be done by just updating the enum cases and docs) |
+1 |
Hey folks, Added fix to upload-symbol and it should ship with the next release 10.23.0, unblocked to identify |
thx @themiswang! 👍🏻 |
@themiswang Thank you! |
The fix is merged. 10.23.0 should release the week of March 19th |
Thank you very much 🥽🥽🥽 |
Description
The flags present in Crashlytics
upload-symbols
at the moment (10.20.0) are:Of these, the
<platform name>
includesios
for official support, andmac
andtvos
for community support.Today, the support for visionOS is in community support, to which I would like to add visionOS.
BTW, in my App project running on visionOS Simulator, I uploaded the dSYM by passing
ios
to--platform
inupload-symbols
and then uploaded it to I generated a test crash following the instructions in https://firebase.google.com/docs/crashlytics/test-implementation?platform=ios and it showed up in its dashboard 🎉However, the operating system is shown as "iOS 1" (originally "visionOS 1") 😆
API Proposal
Add
"visionos"
to<platform name>
inupload-symbols
Firebase Product(s)
Crashlytics
The text was updated successfully, but these errors were encountered: