Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRDocumentChange newIndex not being set as NSNotFound #3298

Closed
Ehesp opened this issue Jul 3, 2019 · 4 comments
Closed

FIRDocumentChange newIndex not being set as NSNotFound #3298

Ehesp opened this issue Jul 3, 2019 · 4 comments
Assignees
Milestone

Comments

@Ehesp
Copy link
Member

@Ehesp Ehesp commented Jul 3, 2019

[REQUIRED] Step 2: Describe your environment

  • Xcode version: 10.2.1
  • Firebase SDK version: 5.20.2
  • Firebase Component: Firestore
  • Component version: 5.20.2 (I think)

[REQUIRED] Step 3: Describe the problem

When removing documents from a collection, the document changes for those removed documents contain the wrong value for the newIndex. The code states it should be equal to NSNotFound, however it's returning -1 which gets converted to 4294967295.

It's worth noting that oldIndex returns the correct value of NSNotFound.

Steps to reproduce:

  1. Add a document to a collection.
  2. Remove the document.
  3. View the newIndex of that document withing document changes.

image

@wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jul 11, 2019

It looks like we broke this in #2608 and there's apparently no test that validates these values. For now the workaround would be to test if the value is >= NSNotFound. We'll put together a fix in the meantime.

@Ehesp
Copy link
Member Author

@Ehesp Ehesp commented Jul 12, 2019

Thanks @wilhuff!

@wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jul 16, 2019

The fix for this will go out with the next release.

@wilhuff wilhuff added this to the M52 milestone Jul 16, 2019
@Salakar
Copy link
Member

@Salakar Salakar commented Jul 22, 2019

Thanks for the quick fix & release @wilhuff 🎉

@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants