Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile errors in Combine #11610

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

peterfriese
Copy link
Contributor

@peterfriese peterfriese commented Jul 26, 2023

#11231 introduces some renamed methods, which broke the Combine build, see this workflow run: https://github.com/firebase/firebase-ios-sdk/actions/runs/5665691823

This PR should fix this.

#no-changelog

This fixes compile errors that result from some method renamings in #11231

Signed-off-by: Peter Friese <peter@peterfriese.de>
Signed-off-by: Peter Friese <peter@peterfriese.de>
@peterfriese peterfriese marked this pull request as ready for review July 26, 2023 10:28
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Peter! LGTM.

@andrewheard andrewheard merged commit 959cf0d into master Jul 26, 2023
23 checks passed
@andrewheard andrewheard deleted the peterfriese/fix-combine-compileerrors branch July 26, 2023 13:44
andrewheard added a commit that referenced this pull request Jul 26, 2023
andrewheard added a commit that referenced this pull request Jul 26, 2023
Reverted reCAPTCHA <-> Auth integration PRs (#11231, #11606, #11609, #11610) due to an issue with the zip build.
@firebase firebase locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants