Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Revert reCAPTCHA integration PRs #11617

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Jul 26, 2023

Reverting these due to an issue with the zip build -- pulling these changes out of the 10.13.0 release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

Apple API Diff Report

Commit: bd07e9f
Last updated: Wed Jul 26 10:45 PDT 2023
View workflow logs & download artifacts


FirebaseAuth

Enumerations

FIRAuthErrorCode
[REMOVED] FIRAuthErrorCodeInvalidRecaptchaAction
Swift:
-  case invalidRecaptchaAction = 17203
Objective-C:
-  FIRAuthErrorCodeInvalidRecaptchaAction = 17203
[REMOVED] FIRAuthErrorCodeInvalidRecaptchaVersion
Swift:
-  case invalidRecaptchaVersion = 17206
Objective-C:
-  FIRAuthErrorCodeInvalidRecaptchaVersion = 17206
[MODIFIED] FIRAuthErrorCodeMissingClientIdentifier
Swift:
+  case missingClientIdentifier = 17993
-  case missingClientIdentifier = 17093
Objective-C:
+  FIRAuthErrorCodeMissingClientIdentifier = 17993
-  FIRAuthErrorCodeMissingClientIdentifier = 17093
[REMOVED] FIRAuthErrorCodeMissingRecaptchaToken
Swift:
-  case missingRecaptchaToken = 17201
Objective-C:
-  FIRAuthErrorCodeMissingRecaptchaToken = 17201
[REMOVED] FIRAuthErrorCodeInvalidReqType
Swift:
-  case invalidReqType = 17207
Objective-C:
-  FIRAuthErrorCodeInvalidReqType = 17207
[REMOVED] FIRAuthErrorCodeRecaptchaSDKNotLinked
Swift:
-  case recaptchaSDKNotLinked = 17208
Objective-C:
-  FIRAuthErrorCodeRecaptchaSDKNotLinked = 17208
[REMOVED] FIRAuthErrorCodeMissingRecaptchaVersion
Swift:
-  case missingRecaptchaVersion = 17205
Objective-C:
-  FIRAuthErrorCodeMissingRecaptchaVersion = 17205
[REMOVED] FIRAuthErrorCodeRecaptchaNotEnabled
Swift:
-  case recaptchaNotEnabled = 17200
Objective-C:
-  FIRAuthErrorCodeRecaptchaNotEnabled = 17200
[REMOVED] FIRAuthErrorCodeMissingClientType
Swift:
-  case missingClientType = 17204
Objective-C:
-  FIRAuthErrorCodeMissingClientType = 17204
[REMOVED] FIRAuthErrorCodeInvalidRecaptchaToken
Swift:
-  case invalidRecaptchaToken = 17202
Objective-C:
-  FIRAuthErrorCodeInvalidRecaptchaToken = 17202

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@google-oss-bot
Copy link

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (4084532)Merge (fee2cf1)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/blGvHnMQ0Q.html

@google-oss-bot
Copy link

google-oss-bot commented Jul 26, 2023

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from ? (4084532) to 68.89% (bd07e9f) by ?.

    117 individual files with coverage change

    FilenameBase (4084532)Merge (bd07e9f)Diff
    FIRActionCodeSettings.m?100.00%?
    FIRAdditionalUserInfo.m?92.31%?
    FIRAuth.m?80.49%?
    FIRAuthAPNSToken.m?100.00%?
    FIRAuthAPNSTokenManager.m?55.62%?
    FIRAuthAppCredential.m?91.30%?
    FIRAuthAppCredentialManager.m?100.00%?
    FIRAuthBackend+MultiFactor.m?37.89%?
    FIRAuthBackend.m?82.20%?
    FIRAuthCredential.m?38.89%?
    FIRAuthDataResult.m?41.38%?
    FIRAuthDefaultUIDelegate.m?0.00%?
    FIRAuthDispatcher.m?100.00%?
    FIRAuthErrorUtils.m?72.27%?
    FIRAuthExceptionUtils.m?0.00%?
    FIRAuthGlobalWorkQueue.m?100.00%?
    FIRAuthKeychainServices.m?59.66%?
    FIRAuthNotificationManager.m?84.68%?
    FIRAuthProtoFinalizeMFAPhoneRequestInfo.m?0.00%?
    FIRAuthProtoFinalizeMFAPhoneResponseInfo.m?0.00%?
    FIRAuthProtoFinalizeMFATOTPEnrollmentRequestInfo.m?100.00%?
    FIRAuthProtoFinalizeMFATOTPEnrollmentResponseInfo.m?0.00%?
    FIRAuthProtoFinalizeMFATOTPSignInRequestInfo.m?100.00%?
    FIRAuthProtoMFAEnrollment.m?89.47%?
    FIRAuthProtoStartMFAPhoneRequestInfo.m?0.00%?
    FIRAuthProtoStartMFAPhoneResponseInfo.m?0.00%?
    FIRAuthProtoStartMFATOTPEnrollmentRequestInfo.m?100.00%?
    FIRAuthProtoStartMFATOTPEnrollmentResponseInfo.m?0.00%?
    FIRAuthRequestConfiguration.m?100.00%?
    FIRAuthSerialTaskQueue.m?100.00%?
    FIRAuthSettings.m?58.33%?
    FIRAuthStoredUserManager.m?52.87%?
    FIRAuthTokenResult.m?78.67%?
    FIRAuthURLPresenter.m?51.68%?
    FIRAuthUserDefaults.m?100.00%?
    FIRAuthWebUtils.m?95.51%?
    FIRAuthWebView.m?0.00%?
    FIRAuthWebViewController.m?0.00%?
    FIRCreateAuthURIRequest.m?61.29%?
    FIRCreateAuthURIResponse.m?100.00%?
    FIRDeleteAccountRequest.m?100.00%?
    FIRDeleteAccountResponse.m?100.00%?
    FIREmailAuthProvider.m?54.55%?
    FIREmailLinkSignInRequest.m?90.91%?
    FIREmailLinkSignInResponse.m?60.87%?
    FIREmailPasswordAuthCredential.m?34.04%?
    FIRFacebookAuthCredential.m?38.46%?
    FIRFacebookAuthProvider.m?37.50%?
    FIRFinalizeMFAEnrollmentRequest.m?64.29%?
    FIRFinalizeMFAEnrollmentResponse.m?0.00%?
    FIRFinalizeMFASignInRequest.m?87.50%?
    FIRFinalizeMFASignInResponse.m?0.00%?
    FIRGameCenterAuthCredential.m?0.00%?
    FIRGameCenterAuthProvider.m?0.00%?
    FIRGetAccountInfoRequest.m?100.00%?
    FIRGetAccountInfoResponse.m?80.00%?
    FIRGetOOBConfirmationCodeRequest.m?84.91%?
    FIRGetOOBConfirmationCodeResponse.m?100.00%?
    FIRGetProjectConfigRequest.m?100.00%?
    FIRGetProjectConfigResponse.m?64.29%?
    FIRGitHubAuthCredential.m?38.46%?
    FIRGitHubAuthProvider.m?37.50%?
    FIRGoogleAuthCredential.m?40.00%?
    FIRGoogleAuthProvider.m?37.50%?
    FIRIdentityToolkitRequest.m?91.67%?
    FIRMultiFactor.m?12.12%?
    FIRMultiFactorInfo.m?89.29%?
    FIRMultiFactorResolver.m?11.34%?
    FIRMultiFactorSession.m?0.00%?
    FIROAuthCredential.m?50.00%?
    FIROAuthProvider.m?85.93%?
    FIRPhoneAuthCredential.m?31.37%?
    FIRPhoneAuthProvider.m?56.02%?
    FIRPhoneMultiFactorAssertion.m?0.00%?
    FIRPhoneMultiFactorGenerator.m?0.00%?
    FIRPhoneMultiFactorInfo.m?86.36%?
    FIRResetPasswordRequest.m?89.47%?
    FIRResetPasswordResponse.m?100.00%?
    FIRRevokeTokenRequest.m?100.00%?
    FIRRevokeTokenResponse.m?100.00%?
    FIRSecureTokenRequest.m?56.82%?
    FIRSecureTokenResponse.m?0.00%?
    FIRSecureTokenService.m?91.39%?
    FIRSendVerificationCodeRequest.m?93.10%?
    FIRSendVerificationCodeResponse.m?57.14%?
    FIRSetAccountInfoRequest.m?96.61%?
    FIRSetAccountInfoResponse.m?100.00%?
    FIRSignInWithGameCenterRequest.m?100.00%?
    FIRSignInWithGameCenterResponse.m?100.00%?
    FIRSignUpNewUserRequest.m?94.44%?
    FIRSignUpNewUserResponse.m?100.00%?
    FIRStartMFAEnrollmentRequest.m?62.16%?
    FIRStartMFAEnrollmentResponse.m?0.00%?
    FIRStartMFASignInRequest.m?0.00%?
    FIRStartMFASignInResponse.m?0.00%?
    FIRTOTPMultiFactorAssertion.m?0.00%?
    FIRTOTPMultiFactorGenerator.m?0.00%?
    FIRTOTPMultiFactorInfo.m?0.00%?
    FIRTOTPSecret.m?0.00%?
    FIRTwitterAuthCredential.m?40.00%?
    FIRTwitterAuthProvider.m?37.50%?
    FIRUser.m?71.07%?
    FIRUserInfoImpl.m?93.75%?
    FIRUserMetadata.m?86.36%?
    FIRVerifyAssertionRequest.m?91.36%?
    FIRVerifyAssertionResponse.m?87.50%?
    FIRVerifyClientRequest.m?100.00%?
    FIRVerifyClientResponse.m?100.00%?
    FIRVerifyCustomTokenRequest.m?89.47%?
    FIRVerifyCustomTokenResponse.m?100.00%?
    FIRVerifyPasswordRequest.m?94.12%?
    FIRVerifyPasswordResponse.m?62.50%?
    FIRVerifyPhoneNumberRequest.m?82.76%?
    FIRVerifyPhoneNumberResponse.m?81.25%?
    FIRWithdrawMFARequest.m?0.00%?
    FIRWithdrawMFAResponse.m?0.00%?
    NSData+FIRBase64.m?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hDrPsSEYQA.html

@andrewheard andrewheard merged commit 24c9cba into master Jul 26, 2023
43 checks passed
@andrewheard andrewheard deleted the ah/revert-auth-recaptcha branch July 26, 2023 18:20
renkelvin pushed a commit that referenced this pull request Aug 15, 2023
@firebase firebase locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants