Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore 10.23.0 versions to main after 10.22.1 #12497

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Mar 8, 2024

Fix #12494

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and will need to re-stage the GoogleAppMeasurementOnDeviceConversion.podspec. Was this the culprit of the nightly failure or was it that SpecsStaging had 10.22.1 pods?

@ncooke3
Copy link
Member

ncooke3 commented Mar 8, 2024

LGTM, and will need to re-stage the GoogleAppMeasurementOnDeviceConversion.podspec. Was this the culprit of the nightly failure or was it that SpecsStaging had 10.22.1 pods?

Ah, it looks like the the 10.22.1 pods confused the builder: https://github.com/firebase/firebase-ios-sdk/actions/runs/8198520159/job/22422203430#step:7:109

@paulb777
Copy link
Member Author

paulb777 commented Mar 8, 2024

But still failed after removing from SpecsStaging https://github.com/firebase/firebase-ios-sdk/actions/runs/8198520159 leading to this PR ...

@paulb777 paulb777 merged commit 48a77e3 into main Mar 8, 2024
52 checks passed
@paulb777 paulb777 deleted the pb-restore-10.23-versions branch March 8, 2024 15:28
@paulb777
Copy link
Member Author

paulb777 commented Mar 8, 2024

Restaging now

@ncooke3
Copy link
Member

ncooke3 commented Mar 8, 2024

Restaging now

@paulb777, fyi, the pod was staged without --use-json which is ok, but there are now two copies: one json (tooling uses --use-json), one ruby: https://github.com/firebase/SpecsStaging/tree/main/GoogleAppMeasurementOnDeviceConversion/10.23.0

The JSON one should be removed since it's the older one.

@paulb777
Copy link
Member Author

paulb777 commented Mar 8, 2024

Repushed a new json one and removed the non-json one.

Good catch! thanks

@firebase firebase locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
4 participants