Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoreInternal] Make test encoder deterministic to avoid Xcode 15 flakiness #12761

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[CoreInternal] Make test encoder deterministic to avoid Xcode 15 flakiness #12761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions FirebaseCore/Internal/Tests/Unit/HeartbeatTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,20 @@ class HeartbeatTests: XCTestCase {
var heartbeat: Heartbeat!
var heartbeatData: Data!

var deterministicEncoder: JSONEncoder = {
let encoder = JSONEncoder()
encoder.outputFormatting = .sortedKeys
return encoder
}()

override func setUpWithError() throws {
heartbeat = Heartbeat(
agent: "dummy_agent",
date: Date(timeIntervalSince1970: 1_635_739_200), // 2021-11-01
timePeriods: [.daily],
version: 100
)
heartbeatData = try JSONEncoder().encode(heartbeat)
heartbeatData = try deterministicEncoder.encode(heartbeat)
}

func testHeartbeatCurrentVersion() throws {
Expand All @@ -67,7 +73,7 @@ class HeartbeatTests: XCTestCase {
let decodedHeartbeat = try JSONDecoder()
.decode(Heartbeat.self, from: data)

let encodedHeartbeat = try JSONEncoder()
let encodedHeartbeat = try deterministicEncoder
.encode(decodedHeartbeat)

// Then
Expand Down
Loading