Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreInternal] Make test encoder deterministic to avoid Xcode 15 flakiness #12761

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 11, 2024

#no-changelog

@ncooke3 ncooke3 changed the title [CoreInternsal] Make test encoder deterministic to avoid Xcode 15 flakiness [CoreInternal] Make test encoder deterministic to avoid Xcode 15 flakiness Apr 11, 2024
@ncooke3 ncooke3 requested a review from paulb777 April 11, 2024 21:27
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM on green.

@paulb777
Copy link
Member

Oh tests are failing because I haven't merged the podspec fixes yet.

I'll merge when I'm ready to restart another round of tests.

@paulb777 paulb777 merged commit 2c91f1e into pb-end-xcode14 Apr 11, 2024
73 of 78 checks passed
@paulb777 paulb777 deleted the nc/core-internal-fix branch April 11, 2024 22:47
@firebase firebase locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants