Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FIRAnalyticsConfiguration from Public header. #2728

Merged
merged 3 commits into from Apr 8, 2019

Conversation

@ryanwilson
Copy link
Member

@ryanwilson ryanwilson commented Apr 4, 2019

We haven't removed it entirely yet because we need to make changes
within Analytics to verify that the global data collection switch is
still honored and tested well. This can wait until after the breaking
change because the header and code will be internal after this change.

We haven't removed it entirely yet because we need to make changes
within Analytics to verify that the global data collection switch is
still honored and tested well. This can wait until after the breaking
change because the header and code will be internal after this change.
@ryanwilson ryanwilson added this to the Firebase 6 milestone Apr 4, 2019
@ryanwilson ryanwilson requested a review from paulb777 Apr 5, 2019
@ryanwilson ryanwilson merged commit 626bfb5 into master Apr 8, 2019
2 checks passed
@ryanwilson ryanwilson deleted the rw-analytics-config-privitize branch Apr 8, 2019
Corrob added a commit that referenced this issue Apr 25, 2019
* Remove FIRAnalyticsConfiguration from Public header.

We haven't removed it entirely yet because we need to make changes
within Analytics to verify that the global data collection switch is
still honored and tested well. This can wait until after the breaking
change because the header and code will be internal after this change.

* Fixed incomplete comment.

* Remove self importing header.
@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants