Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FIRAnalyticsConfiguration from Public header. #2728

Merged
merged 3 commits into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@ryanwilson
Copy link
Member

commented Apr 4, 2019

We haven't removed it entirely yet because we need to make changes
within Analytics to verify that the global data collection switch is
still honored and tested well. This can wait until after the breaking
change because the header and code will be internal after this change.

Remove FIRAnalyticsConfiguration from Public header.
We haven't removed it entirely yet because we need to make changes
within Analytics to verify that the global data collection switch is
still honored and tested well. This can wait until after the breaking
change because the header and code will be internal after this change.

@googlebot googlebot added the cla: yes label Apr 4, 2019

@ryanwilson ryanwilson added this to the Firebase 6 milestone Apr 4, 2019

@ryanwilson ryanwilson added the api: core label Apr 4, 2019

@ryanwilson ryanwilson requested a review from paulb777 Apr 5, 2019

@ryanwilson ryanwilson merged commit 626bfb5 into master Apr 8, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ryanwilson ryanwilson deleted the rw-analytics-config-privitize branch Apr 8, 2019

Corrob added a commit that referenced this pull request Apr 25, 2019

Remove FIRAnalyticsConfiguration from Public header. (#2728)
* Remove FIRAnalyticsConfiguration from Public header.

We haven't removed it entirely yet because we need to make changes
within Analytics to verify that the global data collection switch is
still honored and tested well. This can wait until after the breaking
change because the header and code will be internal after this change.

* Fixed incomplete comment.

* Remove self importing header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.