Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix headers imports moved private #2784

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Fix headers imports moved private #2784

merged 1 commit into from
Apr 10, 2019

Conversation

maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Apr 9, 2019 •
edited
Loading

Related to #2728

Required to fix 1p

@maksymmalyhin maksymmalyhin added this to the Firebase 6 milestone Apr 9, 2019
@maksymmalyhin maksymmalyhin self-assigned this Apr 9, 2019
@paulb777
Copy link
Member

paulb777 commented Apr 9, 2019

Presumably temporary until 1P can directly use the Analytics headers?

@maksymmalyhin
Copy link
Contributor Author

@paulb777 As far as I understand, yes. @ryanwilson would you be able to confirm?

ryanwilson
ryanwilson approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! Although the FIRConfigurationInternal.h import deletion is permanent.

@maksymmalyhin maksymmalyhin merged commit 423959a into master Apr 10, 2019
@maksymmalyhin maksymmalyhin deleted the mm/core-fixes branch April 10, 2019 14:55
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@maksymmalyhin @Corrob
Fix headers imports moved private (#2784)
0d13854
@firebase firebase locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees

@maksymmalyhin maksymmalyhin

Labels
cla: yes
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maksymmalyhin @paulb777 @ryanwilson @googlebot