Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods 1.7.0 multiproject support (b/128794527) #2751

Merged
merged 44 commits into from Apr 9, 2019
Merged

Conversation

@maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Apr 8, 2019

  • header imports fixes - use modular headers where required
  • test project to validate different Cocoapods versions
  • Travis configuration
.travis.yml Outdated
- stage: cocoapods_compatibility_check
name: Validate all Cocoapods configurations
script:
# TODO: ./scripts/if_changed.sh to ./scripts/if_cron.sh once testing finished
Copy link
Contributor Author

@maksymmalyhin maksymmalyhin Apr 8, 2019

I would like to test it together with other tests before merging. I'll change it once it's tested.

@@ -0,0 +1,17 @@
//
// AppDelegate.h
Copy link
Member

@paulb777 paulb777 Apr 8, 2019

update licenses and include in style.sh

@@ -0,0 +1,102 @@
#!/usr/bin/env bash

# Copyright 2018 Google
Copy link
Member

@paulb777 paulb777 Apr 8, 2019

2019 here and other new files

.travis.yml Outdated
name: Validate all Cocoapods configurations
script:
# TODO: ./scripts/if_changed.sh to ./scripts/if_cron.sh once testing finished
- travis_retry ./scripts/if_changed.sh ./CocoapodsIntegrationTest/scripts/build_all_environments.sh
Copy link
Member

@paulb777 paulb777 Apr 8, 2019

Should it be if_cron now?

Copy link
Contributor Author

@maksymmalyhin maksymmalyhin Apr 8, 2019

I would like to run it one more time from the PR. I'll change it to if_cron once the build passes.

}


- (void)applicationWillResignActive:(UIApplication *)application {
Copy link
Member

@ryanwilson ryanwilson Apr 8, 2019

Nit: if these unused methods are going to stay empty, I think we just just remove them from the file.

@maksymmalyhin
Copy link
Contributor Author

@maksymmalyhin maksymmalyhin commented Apr 9, 2019

This build illustrates the checks to be run for cron builds https://travis-ci.org/firebase/firebase-ios-sdk/builds/517562628

Copy link
Member

@paulb777 paulb777 left a comment

This is great. Nice work!

@@ -1,4 +1,6 @@
# Unreleased
- `GULAppDelegateSwizzler`: support of remote notification methods. (#2698)
Copy link
Member

@paulb777 paulb777 Apr 9, 2019

Is this file intended to be in this PR?

Copy link
Contributor Author

@maksymmalyhin maksymmalyhin Apr 9, 2019

Well, probably, the changelog changes should have been better be in a different PR, but I would prefer to merge the PR to avoid waiting for another build to finish.

@maksymmalyhin
Copy link
Contributor Author

@maksymmalyhin maksymmalyhin commented Apr 9, 2019

@paulb777 Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants