Add Sign in with apple with experimental #3162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renkelvin
suggested changes
Jun 10, 2019
|
CI now failed because |
This comment has been minimized.
This comment has been minimized.
|
Officially supported in 6.13.0 🎉 #3145 |
|
Thanks @d-date for prototyping this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
As announcement from WWDC, we need to implement signing in with Apple.
#3145
This is experimental since still beta-1 releasing.
API Changes
No effect for existing APIs.
Note
Since Swift runtime API has introduced from iOS 13, I think you need to rewrite with Swift to adopt Swift packages. Do you have any plan to do that?