Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop flooding Swift Package Manager projects with Firebase test schemes #8212

Merged
merged 3 commits into from
Jun 8, 2021

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 7, 2021

Fix #8167

Move SPM test schemes into place only for CI and internal development. Additional context at https://forums.swift.org/t/swiftpm-and-library-unit-testing/26255/21

Also, updated schemes with enabling analyzer to mitigate conflicts with in-flight #8208, #8209, and #8210

@google-oss-bot
Copy link

google-oss-bot commented Jun 8, 2021

Coverage Report

Affected SDKs

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    SDK overall coverage changed from 56.95% (85ca3cb) to 57.10% (3d46ec8) by +0.15%.

    Filename Base (85ca3cb) Head (3d46ec8) Diff
    FSRWebSocket.m 39.95% 41.78% +1.83%
  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    SDK overall coverage changed from 75.57% (85ca3cb) to 57.21% (3d46ec8) by -18.36%.

    Filename Base (85ca3cb) Head (3d46ec8) Diff
    FDLUtilities.m 90.15% 73.48% -16.67%
    FIRDLDefaultRetrievalProcessV2.m 72.92% 0.00% -72.92%
    FIRDLJavaScriptExecutor.m 82.48% 0.00% -82.48%
    FIRDLRetrievalProcessFactory.m 100.00% 0.00% -100.00%
    FIRDynamicLinkNetworking.m 80.83% 44.44% -36.39%
    FIRDynamicLinks.m 69.84% 67.94% -1.90%
  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    SDK overall coverage changed from 88.44% (85ca3cb) to 88.47% (3d46ec8) by +0.03%.

    Filename Base (85ca3cb) Head (3d46ec8) Diff
    exception.cc 25.00% 77.08% +52.08%
    exception_apple.mm 89.66% 58.62% -31.03%
    leveldb_key.cc 97.81% 96.79% -1.02%
    task.cc 96.41% 95.21% -1.20%

Test Logs

@paulb777 paulb777 requested a review from ryanwilson June 8, 2021 02:36
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice clean up, thank you!

@@ -148,6 +148,7 @@ Alternatively disable signing in each target:
* Add `CODE_SIGNING_REQUIRED` setting with a value of `NO`

### Swift Package Manager
* To enable test schemes: `./scripts/setup_spm_tests.sh`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I will miss this step all the time in the future 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's annoying, but as far as I can tell worth it because of the product advantages for clients. 😛

@paulb777 paulb777 merged commit ec7c826 into master Jun 8, 2021
@paulb777 paulb777 deleted the pb-spm-schemes branch June 8, 2021 14:29
@firebase firebase locked and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase Flooding Project with Build Schemes
4 participants