-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop flooding Swift Package Manager projects with Firebase test schemes #8212
Conversation
Coverage ReportAffected SDKs
Test Logs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice clean up, thank you!
@@ -148,6 +148,7 @@ Alternatively disable signing in each target: | |||
* Add `CODE_SIGNING_REQUIRED` setting with a value of `NO` | |||
|
|||
### Swift Package Manager | |||
* To enable test schemes: `./scripts/setup_spm_tests.sh` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I will miss this step all the time in the future 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's annoying, but as far as I can tell worth it because of the product advantages for clients. 😛
Fix #8167
Move SPM test schemes into place only for CI and internal development. Additional context at https://forums.swift.org/t/swiftpm-and-library-unit-testing/26255/21
Also, updated schemes with enabling analyzer to mitigate conflicts with in-flight #8208, #8209, and #8210