Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Config Swift APIs #9162

Closed
wants to merge 4 commits into from

Conversation

fumito-ito
Copy link
Contributor

@fumito-ito fumito-ito commented Jan 5, 2022

refs: #9108

Why ?

I got following message on twitter for my library, SwiftyRemoteConfig.

Looks promising. We'll be happy to work with you if you want to turn this into PR(s) for a FirebaseRemoteConfigSwift library at

https://twitter.com/paulbeusterien/status/1448001604536307712?s=20

This feature is being considered on #9108.

What ?

This PR add Swifty API interfaces for RemoteConfig (e.g. RawRepresentable and Custom type support !). All features are on CHANGELOG.md

Todo

  • copy and rename files
  • add interface for Swift Package Manager and Cocoapods
  • fix some warnings caused by older OS version.
  • fix some CI settings
  • use project Codable infrastructure a.k.a FirebaseSharedSwift
  • format code according to project style
  • discuss and fix some interface, naming and so on.

@paulb777
Copy link
Member

paulb777 commented Jan 6, 2022

@fumito-ito Thanks so much for creating SwiftyRemoteConfig and sharing it with the Firebase developer community.

Regarding merging this PR, we still need to do some more analysis, but here are some initial thoughts: It looks like SwiftyRemoteConfig strives to address the requirement of defining a great API for Remote Config for users starting without any previous Firebase code or experience.

That does not exactly meet our requirements. We have a large existing developer base and we need to support the developers migrating incrementally on whatever schedule works for them. We want to avoid breaking existing code as much as possible. And we want to support existing code remaining unchanged while new code is developed with a more Swifty API.

Therefore, the best way to make SwiftyRemoteConfig mergeable would be to explore how it can complement the additive approach taken in #9084 to provide additional features.

@fumito-ito
Copy link
Contributor Author

@paulb777 thanks your feedback. #9084 is great work. I have few reviews on it.

@fumito-ito fumito-ito closed this Jan 9, 2022
@fumito-ito fumito-ito deleted the fr-remoteconfig-swift branch January 9, 2022 14:01
@firebase firebase locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants