Remove app-compat from peerDependencies in database-compat (#6319)

firebase · Jun 6, 2022 · 497d34c · 497d34c
1 parent c66d59c
commit 497d34c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/green-turtles-camp.md b/.changeset/green-turtles-camp.md
@@ -0,0 +1,5 @@
+---
+'@firebase/database-compat': patch
+---
+
+Remove app-compat from peerDependencies to avoid npm install warning in firebase-admin.
diff --git a/packages/database-compat/package.json b/packages/database-compat/package.json
@@ -44,9 +44,6 @@
     "test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",
     "add-compat-overloads": "ts-node-script ../../scripts/build/create-overloads.ts -i ../database/dist/public.d.ts -o dist/database-compat/src/index.d.ts -a -r Database:types.FirebaseDatabase -r Query:types.Query -r DatabaseReference:types.Reference -r FirebaseApp:FirebaseAppCompat --moduleToEnhance @firebase/database"
   },
-  "peerDependencies": {
-    "@firebase/app-compat": "0.x"
-  },
   "dependencies": {
     "@firebase/database": "0.13.0",
     "@firebase/database-types": "0.9.8",

diff --git a/packages/database-compat/src/index.node.ts b/packages/database-compat/src/index.node.ts
@@ -14,6 +14,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+// eslint-disable-next-line import/no-extraneous-dependencies
 import firebase from '@firebase/app-compat';
 import { FirebaseNamespace } from '@firebase/app-types';
 import { _FirebaseNamespace } from '@firebase/app-types/private';