Remove app-compat from peerDependencies in database-compat #6319

hsubox76 · 2022-05-31T19:52:22Z

This prevents admin-node users from seeing a warning message during npm/yarn install:
firebase/firebase-admin-node#1656

We're taking the same approach as #2082 in that admin-node users don't need that dep at all, and client JS SDK users of the database-compat package ought to be installing the firebase umbrella package and should never need to worry about @firebase/app-compat not being installed.

changeset-bot · 2022-05-31T19:52:24Z

🦋 Changeset detected

Latest commit: 8fc79ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@firebase/database-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-05-31T19:54:17Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

google-oss-bot · 2022-05-31T20:12:12Z

Size Report ¹

Affected Products

@firebase/app
Type Base (19e37af) Merge (3e56114) Diff
browser 13.8 kB 13.9 kB +84 B (+0.6%)
esm5 18.0 kB 18.1 kB +84 B (+0.5%)
main 19.0 kB 19.1 kB +84 B (+0.4%)
module 13.8 kB 13.9 kB +84 B (+0.6%)
@firebase/app-check
Type Base (19e37af) Merge (3e56114) Diff
browser 25.2 kB 25.3 kB +122 B (+0.5%)
esm5 29.8 kB 29.9 kB +122 B (+0.4%)
main 31.0 kB 31.1 kB +122 B (+0.4%)
module 25.2 kB 25.3 kB +122 B (+0.5%)
@firebase/auth
Type Base (19e37af) Merge (3e56114) Diff
browser ? 155 kB ? (?)
cordova ? 183 kB ? (?)
esm5 ? 202 kB ? (?)
main ? 148 kB ? (?)
module ? 155 kB ? (?)
react-native ? 168 kB ? (?)
@firebase/messaging
Type Base (19e37af) Merge (3e56114) Diff
browser 20.8 kB 21.1 kB +289 B (+1.4%)
esm5 26.2 kB 26.5 kB +289 B (+1.1%)
main 26.9 kB 27.2 kB +289 B (+1.1%)
module 20.8 kB 21.1 kB +289 B (+1.4%)
@firebase/messaging-sw
Type Base (19e37af) Merge (3e56114) Diff
main 29.6 kB 29.9 kB +289 B (+1.0%)
module 22.9 kB 23.2 kB +289 B (+1.3%)
@firebase/remote-config
Type Base (19e37af) Merge (3e56114) Diff
browser 18.8 kB 19.2 kB +331 B (+1.8%)
esm5 23.7 kB 24.0 kB +331 B (+1.4%)
main 24.9 kB 25.2 kB +331 B (+1.3%)
module 18.8 kB 19.2 kB +331 B (+1.8%)
@firebase/storage
Type Base (19e37af) Merge (3e56114) Diff
main 57.3 kB 57.4 kB +84 B (+0.1%)

`bundle`

43 size changes

Type	Base (`19e37af`)	Merge (`3e56114`)	Diff
analytics (logEvent)	41.5 kB	41.6 kB	+76 B (+0.2%)
app-check (CustomProvider)	35.2 kB	35.4 kB	+186 B (+0.5%)
app-check (ReCaptchaEnterpriseProvider)	37.4 kB	37.6 kB	+186 B (+0.5%)
app-check (ReCaptchaV3Provider)	37.4 kB	37.5 kB	+186 B (+0.5%)
auth (Anonymous)	66.1 kB	66.1 kB	+76 B (+0.1%)
auth (EmailAndPassword)	70.2 kB	70.2 kB	+76 B (+0.1%)
auth (GoogleFBTwitterGitHubPopup)	90.0 kB	90.1 kB	+76 B (+0.1%)
auth (GooglePopup)	89.7 kB	89.8 kB	+76 B (+0.1%)
auth (GoogleRedirect)	89.9 kB	90.0 kB	+76 B (+0.1%)
auth (Phone)	76.1 kB	76.2 kB	+76 B (+0.1%)
database (Append to a list of data)	145 kB	145 kB	+76 B (+0.1%)
database (Filtering data)	144 kB	144 kB	+76 B (+0.1%)
database (Listen for child events)	160 kB	160 kB	+76 B (+0.0%)
database (Listen for value events + Detach listeners)	160 kB	160 kB	+76 B (+0.0%)
database (Listen for value events)	160 kB	160 kB	+76 B (+0.0%)
database (Read data once)	152 kB	152 kB	+76 B (+0.1%)
database (Save data as transactions)	162 kB	162 kB	+76 B (+0.0%)
database (Sort data)	146 kB	146 kB	+76 B (+0.1%)
database (Write data)	144 kB	144 kB	+76 B (+0.1%)
firestore (Persistence)	269 kB	269 kB	+76 B (+0.0%)
firestore (Query Cursors)	208 kB	208 kB	+76 B (+0.0%)
firestore (Query)	209 kB	209 kB	+76 B (+0.0%)
firestore (Read data once)	197 kB	197 kB	+76 B (+0.0%)
firestore (Realtime updates)	200 kB	200 kB	+76 B (+0.0%)
firestore (Transaction)	181 kB	181 kB	+76 B (+0.0%)
firestore (Write data)	181 kB	181 kB	+76 B (+0.0%)
firestore-lite (Query Cursors)	67.8 kB	208 kB	+140 kB (+206.6%)
firestore-lite (Query)	71.0 kB	208 kB	+137 kB (+192.6%)
firestore-lite (Read data once)	55.4 kB	197 kB	+142 kB (+256.6%)
firestore-lite (Transaction)	80.0 kB	181 kB	+101 kB (+126.8%)
firestore-lite (Write data)	65.2 kB	181 kB	+116 kB (+177.7%)
functions (call)	29.1 kB	29.2 kB	+76 B (+0.3%)
messaging (send + receive)	44.7 kB	45.0 kB	+303 B (+0.7%)
performance (trace)	49.5 kB	49.6 kB	+76 B (+0.2%)
remote-config (getAndFetch)	43.9 kB	44.2 kB	+375 B (+0.9%)
storage (getBytes)	37.4 kB	37.5 kB	+76 B (+0.2%)
storage (getDownloadURL)	39.5 kB	39.6 kB	+76 B (+0.2%)
storage (getMetadata)	39.0 kB	39.0 kB	+76 B (+0.2%)
storage (list + listAll)	38.4 kB	38.4 kB	+76 B (+0.2%)
storage (updateMetadata)	39.2 kB	39.3 kB	+76 B (+0.2%)
storage (uploadBytes)	43.8 kB	43.8 kB	+76 B (+0.2%)
storage (uploadBytesResumable)	53.2 kB	53.3 kB	+76 B (+0.1%)
storage (uploadString)	44.0 kB	44.0 kB	+76 B (+0.2%)

`firebase`

14 size changes

Type	Base (`19e37af`)	Merge (`3e56114`)	Diff
firebase-app-check-compat.js	22.7 kB	22.8 kB	+84 B (+0.4%)
firebase-app-check.js	90.0 kB	90.2 kB	+175 B (+0.2%)
firebase-app-compat.js	27.6 kB	27.7 kB	+56 B (+0.2%)
firebase-app.js	87.4 kB	87.6 kB	+120 B (+0.1%)
firebase-compat.js	787 kB	788 kB	+787 B (+0.1%)
firebase-firestore-lite.js	267 kB	837 kB	+570 kB (+213.3%)
firebase-firestore.js	837 kB	837 kB	+92 B (+0.0%)
firebase-messaging-compat.js	37.5 kB	37.9 kB	+420 B (+1.1%)
firebase-messaging-sw.js	107 kB	107 kB	+467 B (+0.4%)
firebase-messaging.js	105 kB	106 kB	+467 B (+0.4%)
firebase-performance-standalone-compat.es2017.js	87.4 kB	87.5 kB	+76 B (+0.1%)
firebase-performance-standalone-compat.js	65.3 kB	65.3 kB	+76 B (+0.1%)
firebase-remote-config-compat.js	27.1 kB	27.3 kB	+227 B (+0.8%)
firebase-remote-config.js	112 kB	113 kB	+491 B (+0.4%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/M5BWycIERJ.html

google-oss-bot · 2022-05-31T20:35:30Z

Size Analysis Report ¹

This report is too large (126,731 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/O8wwV0coaM.html

maneesht · 2022-05-31T21:43:14Z

Looks like in packages/database-compat/src/index.node.ts we're using @firebase/app-compat, is that from the symlinked package then?

hsubox76 · 2022-06-02T16:47:11Z

Yes, it's used by both index.node.ts and index.ts. However I'm proposing that it's safe (if a little incorrect) to leave it out of peerDependencies because anyone using builds from index.node.ts or index.ts will be a client-side JS SDK consumer, and they'll already have it installed because npm installing firebase installs everything, including app-compat. Or if they're using it from the CDN, they'll have to have added the app-compat.js script before adding any other products.

Same rationale as outlined in #2082 (where we did the same thing, pre v9).

I've now added an eslint-disable comment in index.node.ts (same as was already in index.ts) to avoid the eslint error from this.

lahirumaramba

Thank you, Christina! LGTM!

Remove app-compat from peerDependencies in database-compat

ca871ed

hsubox76 requested review from maneesht and jsdt as code owners May 31, 2022 19:52

hsubox76 requested a review from lahirumaramba May 31, 2022 19:52

Add eslint disable on app-compat import

27f4751

maneesht approved these changes Jun 2, 2022

View reviewed changes

lahirumaramba approved these changes Jun 2, 2022

View reviewed changes

Add changeset

8fc79ff

hsubox76 requested a review from egilmorez as a code owner June 3, 2022 17:13

hsubox76 merged commit 497d34c into master Jun 6, 2022

hsubox76 deleted the ch-peerdep branch June 6, 2022 16:34

google-oss-bot mentioned this pull request Jun 9, 2022

Version Packages #6347

Merged

lahirumaramba mentioned this pull request Jun 13, 2022

unmet peer dependency "@firebase/app-compat@0.x" firebase/firebase-admin-node#1656

Closed

firebase locked and limited conversation to collaborators Jul 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove app-compat from peerDependencies in database-compat #6319

Remove app-compat from peerDependencies in database-compat #6319

hsubox76 commented May 31, 2022

changeset-bot bot commented May 31, 2022 •

edited

Loading

github-actions bot commented May 31, 2022 •

edited

Loading

google-oss-bot commented May 31, 2022 •

edited

Loading

`@firebase/app`

`@firebase/app-check`

`@firebase/auth`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/remote-config`

`@firebase/storage`

`bundle`

`firebase`

google-oss-bot commented May 31, 2022 •

edited

Loading

maneesht commented May 31, 2022

hsubox76 commented Jun 2, 2022

lahirumaramba left a comment

Remove app-compat from peerDependencies in database-compat #6319

Remove app-compat from peerDependencies in database-compat #6319

Conversation

hsubox76 commented May 31, 2022

changeset-bot bot commented May 31, 2022 • edited Loading

🦋 Changeset detected

github-actions bot commented May 31, 2022 • edited Loading

Changeset File Check ✅

google-oss-bot commented May 31, 2022 • edited Loading

Size Report 1

Affected Products

@firebase/app

@firebase/app-check

@firebase/auth

@firebase/messaging

@firebase/messaging-sw

@firebase/remote-config

@firebase/storage

bundle

firebase

Test Logs

google-oss-bot commented May 31, 2022 • edited Loading

Size Analysis Report 1

Test Logs

maneesht commented May 31, 2022

hsubox76 commented Jun 2, 2022

lahirumaramba left a comment

Choose a reason for hiding this comment

changeset-bot bot commented May 31, 2022 •

edited

Loading

github-actions bot commented May 31, 2022 •

edited

Loading

google-oss-bot commented May 31, 2022 •

edited

Loading

Size Report ¹

`@firebase/app`

`@firebase/app-check`

`@firebase/auth`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/remote-config`

`@firebase/storage`

`bundle`

`firebase`

google-oss-bot commented May 31, 2022 •

edited

Loading

Size Analysis Report ¹