Fix test that randomly started failing with node:test:persistence (#6001

)
firebase · Feb 11, 2022 · 50de44c · 50de44c
1 parent c1b9cf1
commit 50de44c
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/packages/firestore/test/unit/local/indexeddb_persistence.test.ts b/packages/firestore/test/unit/local/indexeddb_persistence.test.ts
@@ -787,19 +787,21 @@ describe('IndexedDbSchema: createOrUpgradeDb', () => {
             DbCollectionParentKey,
             DbCollectionParent
           >(DbCollectionParent.store);
-          return collectionParentsStore.loadAll().next(indexEntries => {
-            const actualParents: { [key: string]: string[] } = {};
-            for (const { collectionId, parent } of indexEntries) {
+          // We use iterate() as loadAll() does not seem to guarantee ordering
+          // with our IndexedDB shim.
+          const actualParents: { [key: string]: string[] } = {};
+          return collectionParentsStore
+            .iterate((_, { collectionId, parent }) => {
               let parents = actualParents[collectionId];
               if (!parents) {
                 parents = [];
                 actualParents[collectionId] = parents;
               }
               parents.push(decodeResourcePath(parent).toString());
-            }
-
-            expect(actualParents).to.deep.equal(expectedParents);
-          });
+            })
+            .next(() => {
+              expect(actualParents).to.deep.equal(expectedParents);
+            });
         }
       );
     });