Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test that randomly started failing with node:test:persistence #6001

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2022

⚠️ No Changeset found

Latest commit: 7815cdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@ehsannas
Copy link
Contributor

I saw this failure locally when I was trying to merge my changes to master last night. I couldn't tell it was because of the getAll change as that PR had a green CI. Just luck i guess.

@schmidt-sebastian schmidt-sebastian merged commit 50de44c into master Feb 11, 2022
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixtext branch February 11, 2022 20:49
@firebase firebase locked and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants