Fixes an unicode encoding issue in firebase-auth.js (#3813)

* escape unicodes * Create honest-doors-poke.md
firebase · Sep 21, 2020 · 7bf7379 · 7bf7379
1 parent 4c4b2d1
commit 7bf7379
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/honest-doors-poke.md b/.changeset/honest-doors-poke.md
@@ -0,0 +1,5 @@
+---
+"firebase": patch
+---
+
+Escape unicodes when generating CDN scripts, so they work correctly in environments that requires UTF-8, for example, in Chrome extension.
diff --git a/packages/firebase/rollup.config.js b/packages/firebase/rollup.config.js
@@ -135,7 +135,14 @@ const componentBuilds = pkg.components
       {
         input: `${component}/index.ts`,
         output: createUmdOutputConfig(`firebase-${component}.js`),
-        plugins: [...plugins, uglify()],
+        plugins: [
+          ...plugins,
+          uglify({
+            output: {
+              ascii_only: true // escape unicode chars
+            }
+          })
+        ],
         external: ['@firebase/app']
       }
     ];