Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes an unicode encoding issue in firebase-auth.js #3813

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Fixes an unicode encoding issue in firebase-auth.js #3813

merged 2 commits into from
Sep 21, 2020

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Sep 18, 2020 •
edited

Fixes #414

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2020 •
edited

🦋 Changeset is good to go

Latest commit: bb088ed

We got this.

This PR includes changesets to release 5 packages
Name Type
firebase Patch
@firebase/rules-unit-testing Patch
@firebase/testing Patch
firebase-namespace-integration-test Patch
firebase-messaging-integration-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 19, 2020 •
edited

Binary Size Report

Affected SDKs

  • firebase

    Type Base (0986b92) Head (d52cbf3) Diff
    firebase-auth.js 174 kB 174 kB +3 B (+0.0%)
    firebase-firestore.js 287 kB 287 kB +39 B (+0.0%)

Test Logs

@Feiyang1 Feiyang1 merged commit 7bf7379 into master Sep 21, 2020
@Feiyang1 Feiyang1 deleted the fei-encoding-fix branch September 21, 2020 16:56
@google-oss-bot google-oss-bot mentioned this pull request Sep 22, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encoding is not UTF-8 error
3 participants
@Feiyang1 @google-oss-bot @hsubox76