Fix ToTP typings issue (#7179)

firebase · Mar 31, 2023 · bd51cec · bd51cec
1 parent 8c9f8c8
commit bd51cec
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/.changeset/soft-zoos-listen.md b/.changeset/soft-zoos-listen.md
@@ -0,0 +1,5 @@
+---
+'@firebase/auth': patch
+---
+
+Fix typings for `TotpMultiFactorGenerator`. This fixes a reversion in 9.19.0.
diff --git a/common/api-review/auth.api.md b/common/api-review/auth.api.md
@@ -754,8 +754,7 @@ export interface TotpMultiFactorAssertion extends MultiFactorAssertion {
 export class TotpMultiFactorGenerator {
     static assertionForEnrollment(secret: TotpSecret, oneTimePassword: string): TotpMultiFactorAssertion;
     static assertionForSignIn(enrollmentId: string, oneTimePassword: string): TotpMultiFactorAssertion;
-    // Warning: (ae-forgotten-export) The symbol "FactorId" needs to be exported by the entry point index.d.ts
-    static FACTOR_ID: FactorId_2;
+    static FACTOR_ID: "totp";
     static generateSecret(session: MultiFactorSession): Promise<TotpSecret>;
 }
 

diff --git a/docs-devsite/auth.totpmultifactorgenerator.md b/docs-devsite/auth.totpmultifactorgenerator.md
@@ -22,7 +22,7 @@ export declare class TotpMultiFactorGenerator
 
 |  Property | Modifiers | Type | Description |
 |  --- | --- | --- | --- |
-|  [FACTOR\_ID](./auth.totpmultifactorgenerator.md#totpmultifactorgeneratorfactor_id) | <code>static</code> | FactorId | The identifier of the TOTP second factor: <code>totp</code>. |
+|  [FACTOR\_ID](./auth.totpmultifactorgenerator.md#totpmultifactorgeneratorfactor_id) | <code>static</code> | 'totp' | The identifier of the TOTP second factor: <code>totp</code>. |
 
 ## Methods
 
@@ -39,7 +39,7 @@ The identifier of the TOTP second factor: `totp`<!-- -->.
 <b>Signature:</b>
 
 ```typescript
-static FACTOR_ID: FactorId;
+static FACTOR_ID: 'totp';
 ```
 
 ## TotpMultiFactorGenerator.assertionForEnrollment()

diff --git a/packages/auth/src/mfa/assertions/totp.ts b/packages/auth/src/mfa/assertions/totp.ts
@@ -107,7 +107,7 @@ export class TotpMultiFactorGenerator {
   /**
    * The identifier of the TOTP second factor: `totp`.
    */
-  static FACTOR_ID = FactorId.TOTP;
+  static FACTOR_ID: 'totp' = FactorId.TOTP;
 }
 
 export class TotpMultiFactorAssertionImpl