Add missing compat Firestore conversion for runTransaction (#5668)

* Add missing compat Firestore conversion for runTransaction * Lint * Create spotty-bags-double.md
firebase · Oct 27, 2021 · f485276 · f485276
1 parent 1048c4f
commit f485276
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changeset/spotty-bags-double.md b/.changeset/spotty-bags-double.md
@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+Add missing compat Firestore conversion for runTransaction
diff --git a/packages/firestore/src/api/transaction.ts b/packages/firestore/src/api/transaction.ts
@@ -20,6 +20,7 @@ import { Transaction as InternalTransaction } from '../core/transaction';
 import { DocumentReference } from '../lite-api/reference';
 import { Transaction as LiteTransaction } from '../lite-api/transaction';
 import { validateReference } from '../lite-api/write_batch';
+import { cast } from '../util/input_validation';
 
 import { ensureFirestoreConfigured, Firestore } from './database';
 import { ExpUserDataWriter } from './reference_impl';
@@ -93,6 +94,7 @@ export function runTransaction<T>(
   firestore: Firestore,
   updateFunction: (transaction: Transaction) => Promise<T>
 ): Promise<T> {
+  firestore = cast(firestore, Firestore);
   const client = ensureFirestoreConfigured(firestore);
   return firestoreClientTransaction(client, internalTransaction =>
     updateFunction(new Transaction(firestore, internalTransaction))