Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing compat Firestore conversion for runTransaction #5668

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Oct 26, 2021

Fixes: #5627

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2021

🦋 Changeset detected

Latest commit: 77f4f3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Oct 26, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 26, 2021

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (f0f6d74) Head (4532b6e) Diff
    browser 225 kB 225 kB +9 B (+0.0%)
    esm5 282 kB 282 kB +9 B (+0.0%)
    main 423 kB 423 kB +36 B (+0.0%)
    module 225 kB 225 kB +9 B (+0.0%)
    react-native 226 kB 226 kB +9 B (+0.0%)
  • firebase

    Type Base (f0f6d74) Head (4532b6e) Diff
    firebase-compat.js 751 kB 751 kB +9 B (+0.0%)
    firebase-firestore-compat.js 278 kB 278 kB +9 B (+0.0%)
    firebase-firestore.js 763 kB 763 kB +12 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 26, 2021

Size Analysis Report

Affected Products

  • @firebase/firestore

    • runTransaction

      Size Table

      TypeBase (f0f6d74)Head (4532b6e)Diff
      size
      104 kB
      104 kB
      +349 B (+0.3%)
      size-with-ext-deps
      153 kB
      153 kB
      +353 B (+0.2%)

      Dependency Table

      TypeBase (f0f6d74)Head (4532b6e)Diff
      functions

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      <full-list-too-large-to-display>
      <see-test-logs-below-for-details>
      

      + ga

@schmidt-sebastian
Copy link
Contributor

Please add changeset for firestore-compat.

@wu-hui wu-hui merged commit f485276 into master Oct 27, 2021
@wu-hui wu-hui deleted the wuandy/TransactionCompat branch October 27, 2021 15:50
@google-oss-bot google-oss-bot mentioned this pull request Oct 27, 2021
@firebase firebase locked and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firestore (v9): Cannot pass compat firestore to modular functions runTransaction and writeBatch
3 participants