Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code keeps auto-importing undefined from 'firebase/empty-import' #2203

Closed
simonhaenisch opened this issue Sep 27, 2019 · 10 comments · Fixed by #2379
Closed

VS Code keeps auto-importing undefined from 'firebase/empty-import' #2203

simonhaenisch opened this issue Sep 27, 2019 · 10 comments · Fixed by #2379
Labels

Comments

@simonhaenisch
Copy link

@simonhaenisch simonhaenisch commented Sep 27, 2019

[REQUIRED] Describe your environment

  • Operating System version: macOS
  • Browser version: _____
  • Firebase SDK version: 7.0.0
  • Firebase Product: empty-import

[REQUIRED] Describe the problem

Every time I type "undefined", VS Code auto-imports

import undefined from 'firebase/empty-import';

This started happening since updating firebase a while ago, and is really inconvenient for the dev experience.

The only thing empty-import.d.ts seems to be good for is to set the typings field on various packages (e. g. here). Can't it

export = {};

instead of export = undefined?

Thanks!

@google-oss-bot

This comment has been minimized.

Copy link

@google-oss-bot google-oss-bot commented Sep 27, 2019

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@Jaki117

This comment has been minimized.

Copy link

@Jaki117 Jaki117 commented Sep 27, 2019

I have the same problem.

@camsjams

This comment has been minimized.

Copy link
Contributor

@camsjams camsjams commented Oct 22, 2019

I have the same issue, its probably occurring 3-5 times a day.

@Kordian-Dziwisz

This comment has been minimized.

Copy link

@Kordian-Dziwisz Kordian-Dziwisz commented Nov 12, 2019

Same
vscode info:

Commit: a3db5be9b5c6ba46bb7555ec5d60178ecc2eaae4
Date: 2019-03-14T23:38:49.842Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.19.80-1-MANJARO```
@mrubiales

This comment has been minimized.

Copy link

@mrubiales mrubiales commented Nov 13, 2019

As a workaround while the issue is fixed I'm pressing
the esc key when VSCode suggest me the Auto import action for undefined.

Captura de pantalla 2019-11-13 a las 14 28 05

@zjaml

This comment has been minimized.

Copy link

@zjaml zjaml commented Nov 23, 2019

Same, unbelievable

@kevinphelps

This comment has been minimized.

Copy link

@kevinphelps kevinphelps commented Nov 25, 2019

This is extremely annoying.

@simonhaenisch

This comment has been minimized.

Copy link
Author

@simonhaenisch simonhaenisch commented Nov 25, 2019

The team just ignoring this issue is even more annoying than the actual issue... not even a comment about why they wouldn't be able to change that 🙄

@bjon

This comment has been minimized.

Copy link

@bjon bjon commented Nov 25, 2019

+1000 so annoying

@camsjams

This comment has been minimized.

Copy link
Contributor

@camsjams camsjams commented Nov 25, 2019

Hopefully they accept my PR: #2379

The original commit that added this export = undefined was from: d96a806#diff-f1b496116df86a8f96044cc9a1a11b9c

I think it aimed to solve: microsoft/TypeScript#6022

@firebase firebase locked and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
10 participants
You can’t perform that action at this time.