-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firebase: Adjust undefined import causing IDE annoyances #2379
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
It probably doesn't make a huge difference, but I'd prefer to change the typing to
declare namespace empty {
}
export = empty;
Can you please also sign the CLA, so we can approve and merge the change?
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@Feiyang1 I agree on the typing, I changed it to an empty namespace per your comment. |
Looks good, Thanks! |
May I pretty please ask to get this published soon? It doesn't solve only the reported issue but for me, it's crashing tsserver and making Typescript experience very unpleasant. |
This change attempts to prevent the auto-importing of an exported
undefined
value fromfirebase/empty-import
, which predominantly occurs in VS Code.Fixes #2203