Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase: Adjust undefined import causing IDE annoyances #2379

Merged
merged 2 commits into from Nov 27, 2019

Conversation

@camsjams
Copy link
Contributor

camsjams commented Nov 25, 2019

This change attempts to prevent the auto-importing of an exported undefined value from firebase/empty-import, which predominantly occurs in VS Code.

Fixes #2203

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 25, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

Feiyang1 left a comment

Thanks so much!
It probably doesn't make a huge difference, but I'd prefer to change the typing to

declare namespace empty {

}
export = empty;

Can you please also sign the CLA, so we can approve and merge the change?

@camsjams

This comment has been minimized.

Copy link
Contributor Author

camsjams commented Nov 27, 2019

@googlebot I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 27, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@camsjams

This comment has been minimized.

Copy link
Contributor Author

camsjams commented Nov 27, 2019

@Feiyang1
Regarding the CLA, I forgot to reply to the bot.

I agree on the typing, I changed it to an empty namespace per your comment.

@Feiyang1

This comment has been minimized.

Copy link
Contributor

Feiyang1 commented Nov 27, 2019

Looks good, Thanks!

@Feiyang1 Feiyang1 merged commit 4313496 into firebase:master Nov 27, 2019
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 89.836%
Details
@FredyC

This comment has been minimized.

Copy link

FredyC commented Dec 4, 2019

May I pretty please ask to get this published soon? It doesn't solve only the reported issue but for me, it's crashing tsserver and making Typescript experience very unpleasant.

microsoft/TypeScript#35036 (comment)

@hsubox76 hsubox76 added this to the 7.5.1 milestone Dec 12, 2019
@firebase firebase locked and limited conversation to collaborators Dec 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.