infer namespace from subdomain in database emulator environment variable #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwski
requested review from
jsdt,
mikelehen and
schmidt-sebastian
as code owners
yuchenshi
requested changes
Jul 23, 2019
yuchenshi
approved these changes
Jul 23, 2019
mikelehen
suggested changes
Jul 24, 2019
mikelehen
reviewed
Jul 24, 2019
mikelehen
approved these changes
Jul 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2005 added support for point the RTDB javascript sdk at the database emulator. This change improves it by inferring the namespace name from the parsed
databaseURLapp option field.