Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak .info/serverTimestampOffset #2061

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Unbreak .info/serverTimestampOffset #2061

merged 3 commits into from
Aug 7, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

Fixes #2043

@schmidt-sebastian schmidt-sebastian mentioned this pull request Aug 7, 2019
Closed
mikelehen
mikelehen approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess large refactors + using any + disabled tests = bugs 😢

@schmidt-sebastian schmidt-sebastian merged commit b1758c4 into master Aug 7, 2019
@zcduthie zcduthie mentioned this pull request Aug 13, 2019
Closed
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/servertimeoffset branch August 29, 2019 04:02
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

@jsdt jsdt Awaiting requested review from jsdt

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

".info/serverTimeOffset" does not work anymore
2 participants
@schmidt-sebastian @mikelehen