Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak .info/serverTimestampOffset #2061

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Unbreak .info/serverTimestampOffset #2061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a4aaba
Unbreak .info/serverTimestampOffset
schmidt-sebastian Aug 7, 2019
715e56a
Remove stale comment
schmidt-sebastian Aug 7, 2019
714261e
Fixes
schmidt-sebastian Aug 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/database/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# Unreleased
- [fixed] Fixed an issue that caused `.info/serverTimeOffset` events not to fire (#2043).

# 6.3.4
- [fixed] Fixed an issue where multi-byte UTF-8 characters would not be written correctly when using `firebase.js` or `firebase-database.js` (#2035).

# 6.0.0
- [changed] Improved consistency between the type annotations for `Query.on`/`Reference.on`,
`Query.off`/`Reference.off` and `Query.once`/`Reference.once` (#1188, #1204).
2 changes: 1 addition & 1 deletion packages/database/src/core/Repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ export class Repo {
}

private onServerInfoUpdate_(updates: Object) {
each(updates, (value: any, key: string) => {
each(updates, (key: string, value: any) => {
this.updateInfo_(key, value);
});
}
Expand Down
4 changes: 1 addition & 3 deletions packages/database/test/info.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,7 @@ describe('.info Tests', function() {
return ea.promise;
});

// Skipping this test as it is expecting a server time diff from a
// local Firebase
it.skip('.info/serverTimeOffset', async function() {
it('.info/serverTimeOffset', async function() {
const ref = getRootNode() as Reference;

// make sure push works
Expand Down