Add open source config and page for RxFire #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
requested review from
Feiyang1,
hiranya911,
hsubox76 and
jamesdaniels
as code owners
Feiyang1
reviewed
Oct 16, 2019
| @@ -0,0 +1,20 @@ | |||
| { | |||
There was a problem hiding this comment.
It controls the appearance of this page
https://firebaseopensource.com/projects/firebase/firebase-js-sdk/
jamesdaniels
approved these changes
Oct 17, 2019
Feiyang1
approved these changes
Oct 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
Adding a better config for the JS SDK on firebaseopensource.com. I removed the centering on the RxJs page since that doesn't play so nice with the open source site.
Testing
N/A
API Changes
N/A