-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messaging rewrite #2484
Merged
Merged
Messaging rewrite #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmermerkaya
requested review from
dwoffinden,
Feiyang1,
hiranya911 and
hsubox76
as code owners
December 31, 2019 20:55
dwoffinden
approved these changes
Jan 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! :D
mmermerkaya
force-pushed
the
mmermerkaya-messaging-refactor
branch
from
January 2, 2020 17:42
d4ee9b6
to
d676026
Compare
hsubox76
reviewed
Jan 2, 2020
mmermerkaya
force-pushed
the
mmermerkaya-messaging-refactor
branch
2 times, most recently
from
January 3, 2020 16:08
04d89c1
to
43fffee
Compare
hsubox76
approved these changes
Jan 6, 2020
mmermerkaya
force-pushed
the
mmermerkaya-messaging-refactor
branch
from
January 9, 2020 09:45
19d4497
to
bffbf56
Compare
mmermerkaya
force-pushed
the
mmermerkaya-messaging-refactor
branch
from
January 9, 2020 11:19
bffbf56
to
0e300e9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't want to leave the FCM SDK in it's current state, so I rewrote a large portion of it (and hopefully without any API changes this time 😄). There are also some API changes that I'd really like to do, like removing
getToken
anddeleteToken
fromSWController
or makingvapidKey
a parameter ofgetToken
, but I guess they'll have to wait.Changes:
BaseController
that the two main controllers were extending and moved the common parts to "token manager" module.DbInterface
, which was not actually an interface but an abstract class, and the two classes that were extending it.subscriptionOptions
subfield. This is now an optional field, as preparation for the eventual Safari support, which will not use the Push API.swScope
as an index, for the same reason as before.any
type from tests. There used to be 83 instances of typeany
in tests.