Untangle ObjectValue and ObjectValueBuilder #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ObjectValue doesn't depend on ObjectValueBuilder and doesn't directly offer the ability to extract field masks, then we can use ObjectValue without pulling in SortedMap and SortedSet.
Binary Size ReportAffected SDKs
Test Logs
|
dconeybe
approved these changes
Apr 23, 2020
| /** | ||
| * Returns a FieldMask built from all fields in an MapValue. | ||
| */ | ||
| export function extractFieldMask(value: api.MapValue): FieldMask { |
There was a problem hiding this comment.
Consider changing the argument of extractFieldMask() from api.MapValue to ObjectValue. With this change, the call sites become more readable. For example,
extractFieldMask(objValue.proto.mapValue!);becomes
extractFieldMask(objValue);There was a problem hiding this comment.
This was how the original call worked, but it used one level of indirection. The method is called recursively and only the first level uses an ObjectValue. I debated passing in just an api.Value, which would act as a sort of compromise. It however hides the fact that the method only works on a MapValue.
There was a problem hiding this comment.
Ahh I see. Feel free to disregard this comment then. The original way you implemented it makes sense.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ObjectValue doesn't depend on ObjectValueBuilder and doesn't directly offer the ability to extract field masks, then we can use ObjectValue without pulling in SortedMap and SortedSet.