Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Closure Compiler ES6 Wildcard import not supported #370

Merged
merged 1 commit into from Jan 25, 2018

Conversation

@Doehl
Copy link
Contributor

commented Dec 12, 2017

Closure compiler does not support ES6 Wildcard export.

By declaring each and every export, can Closure Compiler do its magic.

See: #369 For more details

@jshcrowthe
Copy link
Contributor

left a comment

This LGTM but lets get a small repro of #369 before we merge.

@jshcrowthe jshcrowthe added api: core and removed needs-triage labels Dec 27, 2017

@jshcrowthe jshcrowthe self-assigned this Dec 27, 2017

@jshcrowthe jshcrowthe merged commit 2689287 into firebase:master Jan 25, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.