Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecated] Messaging onPush should await onBackgroundMessage handler (in favor of https://github.com/firebase/firebase-js-sdk/pull/3780) #3726

Closed
wants to merge 1 commit into from

Conversation

niyoko
Copy link

@niyoko niyoko commented Sep 2, 2020

Await onBackgroundMessage handler on onPush method. This PR fixes #3725

@niyoko niyoko requested a review from zwu52 as a code owner September 2, 2020 08:41
@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2020

💥 No Changeset

Latest commit: beed8a6

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@niyoko
Copy link
Author

niyoko commented Sep 2, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@zwu52 zwu52 changed the title Messaging onPush should await onBackgroundMessage handler [Deprecated] Messaging onPush should await onBackgroundMessage handler (in favor of https://github.com/firebase/firebase-js-sdk/pull/3780) Apr 14, 2021
@zwu52 zwu52 closed this Aug 20, 2021
@firebase firebase locked and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onPush not awaiting onBackgroundMessage event handler
3 participants