Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose emulator config for the Auth SDK #4280

Merged
merged 6 commits into from
Jan 13, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jan 12, 2021

Also add the relevant bits to the externs in the firebase package, so that other Closure libraries can consume the new features.

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2021

🦋 Changeset detected

Latest commit: b827513

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@firebase/auth Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping since this is already reviewed internally

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 12, 2021

Size Analysis Report

Affected Products

No changes between base commit (50abe6c) and head commit (d8d1b1c).

Test Logs

@Feiyang1 Feiyang1 removed their assignment Jan 13, 2021
@sam-gc sam-gc merged commit 92a7f43 into master Jan 13, 2021
@sam-gc sam-gc deleted the samgho/auth-emulator-config-getter branch January 13, 2021 22:57
@google-oss-bot google-oss-bot mentioned this pull request Jan 19, 2021
@firebase firebase locked and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants