Fix refFromUrl when used with emulator (#4199)

firebase · Jan 8, 2021 · 50abe6c · 50abe6c
1 parent 34b4e30
commit 50abe6c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 7 deletions.
diff --git a/.changeset/clever-kangaroos-hug.md b/.changeset/clever-kangaroos-hug.md
@@ -0,0 +1,5 @@
+---
+"@firebase/database": patch
+---
+
+Fixes an issue that caused `refFromUrl()` to reject production database URLs when `useEmulator()` was used.
diff --git a/packages/database/src/api/Database.ts b/packages/database/src/api/Database.ts
@@ -156,7 +156,7 @@ export class Database implements FirebaseService {
 
     const repoInfo = parsedURL.repoInfo;
     if (
-      !repoInfo.isCustomHost() &&
+      !this.repo_.repoInfo_.isCustomHost() &&
       repoInfo.host !== this.repo_.repoInfo_.host
     ) {
       fatal(

diff --git a/packages/database/test/database.test.ts b/packages/database/test/database.test.ts
@@ -268,12 +268,12 @@ describe('Database Tests', () => {
   });
 
   it('refFromURL() validates domain', () => {
-    const db = (firebase as any).database();
-    expect(() => {
-      const ref = db.refFromURL(
-        'https://thisisnotarealfirebase.firebaseio.com/path/to/data'
-      );
-    }).to.throw(/does not match.*database/i);
+    const db = (firebase as any)
+      .app()
+      .database('https://thisisreal.firebaseio.com');
+    expect(() =>
+      db.refFromURL('https://thisisnotreal.firebaseio.com/path/to/data')
+    ).to.throw(/does not match.*database/i);
   });
 
   it('refFromURL() validates argument', () => {