Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async isSupported to Modular FM SDK #4665

Merged
merged 18 commits into from
Apr 7, 2021
Merged

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Mar 22, 2021

This PR does 2 things

  • export async isSupported from index.ts and index.sw.ts (API Approved: go/js-messaging-is-supported)
  • separate isWindowSupported and isSwSupported checks in its own context (window and sw respectively)

Deprecating #4446 in favor of this PR

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2021

⚠️ No Changeset found

Latest commit: ed6fa88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 22, 2021

Size Analysis Report

Affected Products

Diffs between base commit (f24d896) and head commit (f16f6d0) are too large (196,985 characters) to display.

Please check below links to see details from the original test log.

@zwu52 zwu52 changed the title Separate window/sw context check Add async isSupported` to Modular Mar 24, 2021
@zwu52 zwu52 changed the title Add async isSupported` to Modular Add async isSupported` to Modular FM SDK Mar 24, 2021
@zwu52 zwu52 changed the title Add async isSupported` to Modular FM SDK Add async isSupported to Modular FM SDK Mar 24, 2021
@zwu52 zwu52 requested a review from Feiyang1 March 31, 2021 17:04
@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

2 similar comments
@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

zwu52 and others added 6 commits April 5, 2021 16:15
Instead of calling `isSupported` in `index.ts` and `index.sw.ts` (Problematic because devs will get error before they can do anything about it).

The correct behavior should be: dev check env by calling isSupported; if they dont call and env not supported, then SDK throw error during messaging intialization stage
Deprecating #4446 in favor of this PR
@zwu52 zwu52 force-pushed the modualr_fm_add_is_supported branch from 279de76 to 4bf341d Compare April 5, 2021 23:20
This reverts commit 4bf341d.
@zwu52 zwu52 requested a review from Feiyang1 April 6, 2021 19:05
@zwu52 zwu52 requested a review from hsubox76 April 6, 2021 22:15
@zwu52 zwu52 requested a review from Feiyang1 April 7, 2021 15:45
@zwu52 zwu52 merged commit 8e1ace4 into master Apr 7, 2021
@zwu52 zwu52 deleted the modualr_fm_add_is_supported branch April 7, 2021 20:48
@firebase firebase locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants